Remove icu::calendar unix epoch APIs
#5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
zbraniecki and
a team
as code owners
robertbastian
force-pushed
the
unix
branch
2 times, most recently
from
1497853
to
20c629a
Compare
sffc
approved these changes
Oct 30, 2024
| /// | ||
| /// assert_eq!(b.days_since(a), 10_917); | ||
| /// ``` | ||
| #[doc(hidden)] // unstable |
There was a problem hiding this comment.
I think I would prefer embracing the replacement APIs but we can do that later
There was a problem hiding this comment.
There is already a hidden until API which is more powerful than this, so I don't want to stabilise this. until is not fully implemented, I'd have used it if the max-unit argument were respected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unix epoch is a physical time concept. It does not work on a civil time API. https://errorprone.info/docs/time