Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve timezone APIs #5747

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Improve timezone APIs #5747

merged 3 commits into from
Oct 30, 2024

Conversation

robertbastian
Copy link
Member

  • Fewer overlapping constructors for TimeZoneInfo
  • Private fields for TimeZoneInfo
  • Return type for ZoneOffsetCalculator
  • docs

@robertbastian robertbastian merged commit 7feeacd into unicode-org:main Oct 30, 2024
28 checks passed
@robertbastian robertbastian deleted the tz branch October 30, 2024 16:11
sffc
sffc reviewed Oct 30, 2024
View reviewed changes
components/datetime/src/fieldset.rs
@@ -1013,7 +1007,7 @@ impl_zone_marker!(
/// only a full time zone info can be formatted with this style.
/// For example, [`TimeZoneInfo<AtTime>`] cannot be formatted.
///
/// ```compile_fail
/// ```compile_fail,E0271
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put the expected error number here? I've never seen that before but I love if it works.

sffc
sffc reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have comments on this but it's merged. I'll leave them after my meetings

@sffc sffc mentioned this pull request Oct 30, 2024
Open
sffc
sffc reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@Manishearth Manishearth Manishearth approved these changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth