-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make an IxdtfParser
type
#5736
Make an IxdtfParser
type
#5736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: Thanks for keeping the function names the same so it is easy to review.
Hmm, how do I load all |
Just put in the bounds like usual: We do this in the DateTimeFormatter constructors, too (they are at the end of the list): |
Oh, since it is cross-crate, you will also need the |
Oh, but you don't know the calendar until parsing time. Hmm. Easy way out is to pass the AnyCalendar provider into the parse function, but that's annoying. Maybe you can save a closure that calls the AnyCalendar constructor as a field of the parser? You'd need to put a lifetime on the parser object, I think. |
Or you could eagerly load all the markers into payloads and then make your own internal DataProvider that reads those payloads when calling |
Based on #5735