Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Format parameter to MultiFieldsULE, add Index8 format #5522

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Add a Format parameter to MultiFieldsULE, add Index8 format #5522

merged 5 commits into from
Sep 10, 2024

Conversation

Manishearth
Copy link
Member

No description provided.

@Manishearth Manishearth requested a review from sffc as a code owner September 9, 2024 17:28
@sffc sffc mentioned this pull request Sep 9, 2024
Open
1 task
sffc
sffc approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test of some sort would be nice, but approving because it's 100% argument marshaling

@Manishearth Manishearth merged commit e266337 into unicode-org:main Sep 10, 2024
28 checks passed
@Manishearth Manishearth deleted the multivar-format branch September 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @sffc