Implement ixdtf for CustomTimeZone and CustomZonedDateTime
#5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Aug 9, 2024
components/timezone/src/ixdtf.rs
Outdated
Comment on lines
280
to
281
| let (year, month, day) = | ||
| date.map(|d| (d.year, d.month, d.day)).unwrap_or((0, 0, 0)); |
There was a problem hiding this comment.
If the date or time is not present, then I think do not calculate the metazone. Only calculate it if all the fields are there.
sffc
approved these changes
Aug 16, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #5201.
It adds the below functionality to
icu_timezone:TryFrom forGmtOffsetCustomTimeZoneCustomZonedDateTimenew_with_bcp47_idmethod toCustomTimeZoneCurrently, the parsing doesn't resolve any inconsistency that may exist between a DateTime UTC Offset and a IANA identifier time zone annotation, going off the documentation comment that
CustomTimeZonedoes not enforce consistency across all fields.