-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin the nightly version in CI #526
Conversation
9f1d87b
to
68c38d8
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
68c38d8
to
aa1c8f0
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
.github/workflows/build-test.yml
Outdated
run: rustup toolchain install nightly | ||
- uses: actions-rs/toolchain@v1 | ||
with: | ||
toolchain: nightly-2020-04-04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you picking such old versions of nightly? Seems like you should pick the most recent version that works (something in 2021, not 2020)
Pull Request Test Coverage Report for Build 5291fb1cbf8150748879d2002bd5bebdddc23e68-PR-526
💛 - Coveralls |
Closer! Coverage is working now, but Memory is still broken:
|
Now that the P0 issue has been fixed (by #529), should we use this PR to pin the version of Rust in both nightly and stable CI builds? And then hopefully unblock adding back CI caching? |
I'm going to go ahead and mark this as ready for review, as the only outstanding CI failure is from: PR #518 |
RSLGTM for the nightly toolchain version. As discussed, we should follow up with a PR to pin the stable version as well. |
This is part of the work for #374. I have several PRs with red CI. I'm keeping this as draft while I work on it.