Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu_datagen_bikeshed -> icu_provider_source #5173

Merged
merged 4 commits into from
Jul 4, 2024
Merged

icu_datagen_bikeshed -> icu_provider_source #5173

merged 4 commits into from
Jul 4, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jul 3, 2024 •
edited
Loading

Part of #4721

RIP Github UI

@sffc
Copy link
Member

sffc commented Jul 4, 2024

Comments from a local review:

  • provider/core/src/lib.rs: Double check the link. It goes to ../icu_provider_export/struct.SourceDataProvider.html which I think is wrong.

Everything else looks as expected.

@robertbastian
Copy link
Member Author

This PR is strictly find-and-replace, I'll do a thorough docs review next.

sffc
sffc previously approved these changes Jul 4, 2024
View reviewed changes
@robertbastian robertbastian requested a review from sffc July 4, 2024 17:55
@robertbastian robertbastian merged commit 0efc535 into unicode-org:main Jul 4, 2024
28 checks passed
@robertbastian robertbastian deleted the source branch July 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbastian @sffc