Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variants are now:
MarkerNotFound
MissingDataMarker
, unclear if it was missing from the request or the dataIdentifierNotFound
MissingLocale
, unclear if it was missing from the request or the data, and needs to use identifier terminologyNeedsLocale
InvalidRequest
ExtraneousLocale
but I think it should cover other illegal requests as wellFiltered
FilteredResource
, but we're not using resource terminology anymoreInconsistentData
Downcast
MismatchedType
, but is only returned fromAnyPayload::downcast
andDowncastingAnyProvider
, so I think this is a better name. Also more symmetric with ...Deserialize
UnavailableBufferFormat
orCustom
before. Now all serde issues return this variant, i.e.DataPayload::deserialize
andDeserializingBufferProvider
Custom
Io
MissingSourceData
DatagenProvider
is just one provider implementation, it can useCustom