Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up DataError #5146

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Cleaning up DataError #5146

merged 3 commits into from
Jun 28, 2024

Conversation

robertbastian
Copy link
Member

The variants are now:

  • MarkerNotFound
    • This was MissingDataMarker, unclear if it was missing from the request or the data
  • IdentifierNotFound
    • This was MissingLocale, unclear if it was missing from the request or the data, and needs to use identifier terminology
  • NeedsLocale
    • The locale is not optional, this was unused
  • InvalidRequest
    • This was ExtraneousLocale but I think it should cover other illegal requests as well
  • Filtered
    • This was FilteredResource, but we're not using resource terminology anymore
  • InconsistentData
  • Downcast
    • This was MismatchedType, but is only returned from AnyPayload::downcast and DowncastingAnyProvider, so I think this is a better name. Also more symmetric with ...
  • Deserialize
    • This was UnavailableBufferFormat or Custom before. Now all serde issues return this variant, i.e. DataPayload::deserialize and DeserializingBufferProvider
  • Custom
  • Io
  • MissingSourceData
    • DatagenProvider is just one provider implementation, it can use Custom

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

provider/adapters/src/fork/mod.rs Outdated Show resolved Hide resolved
@robertbastian robertbastian requested a review from sffc June 28, 2024 11:02
@robertbastian robertbastian merged commit b021268 into unicode-org:main Jun 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants