(Backport to 1.5.x) Fix OptionVarULE in zerovec to also use C, packed #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert was probably meant to ensure the complete year has at least 14 days, and not that the given day is at least the 14th day of the year Fixes: unicode-org#4977 (cherry picked from commit e83fd9b)
unicode-org#4977 (cherry picked from commit fe96085)
Fixes unicode-org#4968 I'd like to make a release for this one because it's a one-line change and we're already working on a patch release. (cherry picked from commit ad65b6d)
Fixes size regression noted by @zbraniecki (cherry picked from commit 9d7c332)
Uplifts unicode-org#5049 to 1.5.x
Fix indentation <!-- Thank you for your pull request to ICU4X! Reminder: try to use [Conventional Comments](https://conventionalcomments.org/) to make comments clearer. Please see https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for general information on contributing to ICU4X. -->
Manishearth
requested review from
zbraniecki,
nordzilla and
a team
as code owners
Manishearth
force-pushed
the
zerovec-patch
branch
from
35409ab to
3aba8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was an oversight from #5049
This will publish zerovec 0.10.4