Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow for LiteMap by using correct Store trait method #5113

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix integer overflow for LiteMap by using correct Store trait method #5113

merged 1 commit into from
Jun 25, 2024

Conversation

jsatka
Copy link
Contributor

@jsatka jsatka commented Jun 25, 2024 •
edited
Loading

In the latest version calling last() on empty LiteMap panics on attempt to subtract with overflow.

The correct method that should be called internally is Store trait method lm_last().

@jsatka jsatka requested review from Manishearth and sffc as code owners June 25, 2024 09:37
@CLAassistant
Copy link

CLAassistant commented Jun 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sffc
Copy link
Member

sffc commented Jun 25, 2024

Oops, thank you!

@robertbastian robertbastian merged commit c824452 into unicode-org:main Jun 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@robertbastian robertbastian robertbastian approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsatka @CLAassistant @sffc @robertbastian