Minor improvement to zerotrie hash function #5106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed our little perfect hash function with @Amanieu who highlighted the modulo operator as likely the performance bottleneck. We brainstormed some various approaches including whether we could clamp the hash table size to a power of 2 so that we could use a bitmask instead of a division. However, there were a few downsides to that approach:
What I did in this PR is change the
usize
division tou8
division. It results in slightly smaller assembly:@Victoronz also pointed me to https://orlp.net/blog/worlds-smallest-hash-table/ which is a good read about perfect hash functions.