Narrow errors for neo datetime #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc
and removed request for
zbraniecki and
nordzilla
robertbastian
commented
May 7, 2024
| ) -> Result<FixedDecimalFormatter, DataError> { | ||
| FixedDecimalFormatter::try_new(locale, options).map_err(|e| match e { | ||
| DecimalError::Data(e) => e, | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
this unreachable branch will disappear in 2.0, when the external constructor can return DataError only. Similar below
|
@robertbastian Can you reference the corresponding issue in the OP? |
|
Done |
sffc
approved these changes
May 7, 2024
| @@ -952,7 +994,7 @@ impl RawDateTimeNames { | |||
| ///// Textual symbols ///// | |||
| FieldSymbol::Era => { | |||
| self.load_year_names( | |||
| year_provider.ok_or(Error::MissingNames(field))?, | |||
| year_provider.ok_or(LoadError::MissingNames(field))?, | |||
There was a problem hiding this comment.
Thought: With the work I'm doing to consolidate the neo formatter types, this error case might go away which would be nice.
|
@robertbastian Also please link the issue about constructor errors, where we listed out the specific cases where returning DataError directly from constructors was acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4336
Per policy in #4638 (comment)