Caching for observational islamic calendar #4770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
previously approved these changes
Apr 5, 2024
|
|
||
| /// Marker type for Saudi islamic calendar, for use with [`IslamicBasedMarker`] | ||
| #[derive(Clone, Copy, Debug, Hash, Eq, PartialEq)] | ||
| pub struct SaudiIslamicMarker; |
There was a problem hiding this comment.
question: why Saudi instead of UmmAlQura?
There was a problem hiding this comment.
That's what the book calls this code; I'm using book names here.
| @@ -17,22 +17,129 @@ const CAIRO: Location = Location { | |||
| zone: (1_f64 / 12_f64), | |||
| }; | |||
|
|
|||
| /// Common abstraction over islamic-style calendars | |||
| pub trait IslamicBasedMarker { | |||
There was a problem hiding this comment.
Thought: This crate isn't really public-facing so API doesn't matter too much, but if this were ICU4X I would probably make the trait contain only the three items that are reasonably implementable, and the things that are not implementable/overridable should go into another struct that has the trait as a generic.
pub struct IslamicCacheCalculator<M> { ... }
impl<M: IslamicBasedMarker> IslamicBasedMarker<M> { ... }There was a problem hiding this comment.
I intend for some of these to be overridden in the long run for performance (it's just annoying to do now)
Co-authored-by: Shane F. Carr <[email protected]>
Co-authored-by: Shane F. Carr <[email protected]>
Manishearth
changed the title
Manishearth
requested review from
robertbastian,
zbraniecki,
nordzilla and
a team
as code owners
sffc
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #3933
Doing the other three should be easy after this.