Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve follow-up comments to #3760 #3818

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Resolve follow-up comments to #3760 #3818

merged 4 commits into from
Aug 9, 2023

Conversation

atcupps
Copy link
Contributor

@atcupps atcupps commented Aug 8, 2023

Resolves #3815

@Manishearth Manishearth merged commit 57e9d59 into unicode-org:main Aug 9, 2023
25 checks passed
skius added a commit to skius/icu4x that referenced this pull request Aug 9, 2023
@skius
Squash of transliterator-ir
d6873b0 
commit c85e861
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:40:53 2023 +0200

    borrow SingleID

commit 06425a1
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:22:03 2023 +0200

    fix comment indentation

commit 2f70922
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:09:13 2023 +0200

    update comments

commit 47444ee
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:06:43 2023 +0200

    fmt

commit c0de3a0
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:03:19 2023 +0200

    fix clippy, allow testing of intermediate pass1 values

commit 227f738
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 16:55:53 2023 +0200

    fix compile errors by introducing 2 small clones per transliterator

commit 512b158
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 16:49:01 2023 +0200

    doesn't compile - missing self deconstruction

commit 7848f09
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 16:40:51 2023 +0200

    use rule group aggregation in pass1

commit 93663e4
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 16:09:29 2023 +0200

    add rule group aggregation

commit 57666eb
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 14:12:19 2023 +0200

    Squash of transliterator-compiler

    commit d1812b4
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 13:31:53 2023 +0200

        fix merge mistake

    commit f15f6eb
    Merge: abb91cc a39cfed
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 13:27:08 2023 +0200

        Merge branch 'main' into transliterator-compiler

    commit abb91cc
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 01:12:13 2023 +0200

        reformat tests

    commit f6a10f5
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 00:30:09 2023 +0200

        sizes => counts

    commit 9ffc2f0
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 00:26:27 2023 +0200

        add more docs

    commit eae5748
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:46:20 2023 +0200

        remove TODO

    commit 6b09689
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:28:42 2023 +0200

        improve docs

    commit c9b16d5
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:15:23 2023 +0200

        clippy

    commit 020a677
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 22:53:14 2023 +0200

        add result aggregation to first pass

    commit 2d1bfd7
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 16:28:23 2023 +0200

        add tests

    commit 6f35ea5
    Author: Niels Saurer <[email protected]>
    Date:   Mon Aug 7 22:25:56 2023 +0200

        CI fixes

    commit c6c4844
    Author: Niels Saurer <[email protected]>
    Date:   Sun Aug 6 20:06:31 2023 +0200

        first steps

    commit fb68218
    Author: Niels Saurer <[email protected]>
    Date:   Wed Jul 19 16:21:33 2023 +0000

        Squash transliterator-parser

        structure for transliterator parser

        start parsing ':: ... ;' rules

        complete ::-rule parsing

        add more global filter tests

        add negative tests for '::'-rules, be more restrictive

        update error docs

        add comment about static UnicodeSet type alias

        add variable defs

        escaping and fix unicodeset handling

        fix unicodeset tests

        function calls

        add variable-inside-unicodesets

        update tests

        rewrite parse_section using parse_element

        fix unquoted literal handling

        add cursor/placeholder tests

        add cursor support

        add allow(unused) for this PR

        remove unused dependencies

        add todo about inefficient unicodeset variablemap handling

        allow usage of UnicodeSet's VariableMap directly in TransliteratorParser

        avoid one allocation per parsed unicodeset

        remove done todo about allocation-free unicodeset parser hook

        avoid allocations for number parsing

        invalid num err with offset

        update comment

        switch to allocation free hex parsing (and support for multi escapes)

        fix main merge conflict

        support \p unicodesets

        remove todo for \p unicodeset parsing

        turn low-prio todo about avoiding clones into note

        turn non-memory-safety safety comments into regular comments

        add issue number to TODOs

        add transliteration component crate

commit a39cfed
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 13:19:28 2023 +0200

    Add Parsing for Rule-Based Transliterators (unicode-org#3730)

commit 57e9d59
Author: Andrew Cupps <[email protected]>
Date:   Tue Aug 8 18:53:26 2023 -0700

    Resolve follow-up comments to unicode-org#3760 (unicode-org#3818)

    * Docs for `U` and `r`

    * Delete empty test and add todo

    * Remove old code and empty era check

    * Add todo
skius added a commit to skius/icu4x that referenced this pull request Aug 9, 2023
@skius
Squash of transliterator-datastruct-generation
89f7b46 
commit ae14cdc
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 21:04:38 2023 +0200

    clippy

commit 8a14e3e
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 21:02:28 2023 +0200

    tutorials cargo lock

commit 4256873
Merge: 72cff57 f549131
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 20:56:20 2023 +0200

    Merge branch 'main' into transliterator-datastruct-generation

commit 72cff57
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 20:42:03 2023 +0200

    refactor pass2 interface

commit 8fa4dfd
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 20:31:29 2023 +0200

    skip compilation of cursors on source side, anchors on target side

commit 54b0542
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 19:09:50 2023 +0200

    add comment

commit cba53a7
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 19:04:27 2023 +0200

    fix clippy warnings

commit 2dd2ec8
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 19:01:15 2023 +0200

    fmt

commit 56774fe
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 18:45:22 2023 +0200

    refactor MutVarTable

commit 6176769
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 18:31:18 2023 +0200

    revamp pass2 API

commit f8459c9
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 18:22:47 2023 +0200

    initial final data struct generation

commit d6873b0
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:48:41 2023 +0200

    Squash of transliterator-ir

    commit c85e861
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:40:53 2023 +0200

        borrow SingleID

    commit 06425a1
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:22:03 2023 +0200

        fix comment indentation

    commit 2f70922
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:09:13 2023 +0200

        update comments

    commit 47444ee
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:06:43 2023 +0200

        fmt

    commit c0de3a0
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:03:19 2023 +0200

        fix clippy, allow testing of intermediate pass1 values

    commit 227f738
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:55:53 2023 +0200

        fix compile errors by introducing 2 small clones per transliterator

    commit 512b158
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:49:01 2023 +0200

        doesn't compile - missing self deconstruction

    commit 7848f09
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:40:51 2023 +0200

        use rule group aggregation in pass1

    commit 93663e4
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:09:29 2023 +0200

        add rule group aggregation

    commit 57666eb
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 14:12:19 2023 +0200

        Squash of transliterator-compiler

        commit d1812b4
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 13:31:53 2023 +0200

            fix merge mistake

        commit f15f6eb
        Merge: abb91cc a39cfed
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 13:27:08 2023 +0200

            Merge branch 'main' into transliterator-compiler

        commit abb91cc
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 01:12:13 2023 +0200

            reformat tests

        commit f6a10f5
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 00:30:09 2023 +0200

            sizes => counts

        commit 9ffc2f0
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 00:26:27 2023 +0200

            add more docs

        commit eae5748
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:46:20 2023 +0200

            remove TODO

        commit 6b09689
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:28:42 2023 +0200

            improve docs

        commit c9b16d5
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:15:23 2023 +0200

            clippy

        commit 020a677
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 22:53:14 2023 +0200

            add result aggregation to first pass

        commit 2d1bfd7
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 16:28:23 2023 +0200

            add tests

        commit 6f35ea5
        Author: Niels Saurer <[email protected]>
        Date:   Mon Aug 7 22:25:56 2023 +0200

            CI fixes

        commit c6c4844
        Author: Niels Saurer <[email protected]>
        Date:   Sun Aug 6 20:06:31 2023 +0200

            first steps

        commit fb68218
        Author: Niels Saurer <[email protected]>
        Date:   Wed Jul 19 16:21:33 2023 +0000

            Squash transliterator-parser

            structure for transliterator parser

            start parsing ':: ... ;' rules

            complete ::-rule parsing

            add more global filter tests

            add negative tests for '::'-rules, be more restrictive

            update error docs

            add comment about static UnicodeSet type alias

            add variable defs

            escaping and fix unicodeset handling

            fix unicodeset tests

            function calls

            add variable-inside-unicodesets

            update tests

            rewrite parse_section using parse_element

            fix unquoted literal handling

            add cursor/placeholder tests

            add cursor support

            add allow(unused) for this PR

            remove unused dependencies

            add todo about inefficient unicodeset variablemap handling

            allow usage of UnicodeSet's VariableMap directly in TransliteratorParser

            avoid one allocation per parsed unicodeset

            remove done todo about allocation-free unicodeset parser hook

            avoid allocations for number parsing

            invalid num err with offset

            update comment

            switch to allocation free hex parsing (and support for multi escapes)

            fix main merge conflict

            support \p unicodesets

            remove todo for \p unicodeset parsing

            turn low-prio todo about avoiding clones into note

            turn non-memory-safety safety comments into regular comments

            add issue number to TODOs

            add transliteration component crate

    commit a39cfed
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 13:19:28 2023 +0200

        Add Parsing for Rule-Based Transliterators (unicode-org#3730)

    commit 57e9d59
    Author: Andrew Cupps <[email protected]>
    Date:   Tue Aug 8 18:53:26 2023 -0700

        Resolve follow-up comments to unicode-org#3760 (unicode-org#3818)

        * Docs for `U` and `r`

        * Delete empty test and add todo

        * Remove old code and empty era check

        * Add todo

commit c55c641
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 02:36:53 2023 +0200

    wip

commit c6cbb0a
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 01:20:08 2023 +0200

    Squash of transliterator-compiler

    commit abb91cc
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 01:12:13 2023 +0200

        reformat tests

    commit f6a10f5
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 00:30:09 2023 +0200

        sizes => counts

    commit 9ffc2f0
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 00:26:27 2023 +0200

        add more docs

    commit eae5748
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:46:20 2023 +0200

        remove TODO

    commit 6b09689
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:28:42 2023 +0200

        improve docs

    commit c9b16d5
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:15:23 2023 +0200

        clippy

    commit 020a677
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 22:53:14 2023 +0200

        add result aggregation to first pass

    commit 2d1bfd7
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 16:28:23 2023 +0200

        add tests

    commit 6f35ea5
    Author: Niels Saurer <[email protected]>
    Date:   Mon Aug 7 22:25:56 2023 +0200

        CI fixes

    commit c6c4844
    Author: Niels Saurer <[email protected]>
    Date:   Sun Aug 6 20:06:31 2023 +0200

        first steps

    commit fb68218
    Author: Niels Saurer <[email protected]>
    Date:   Wed Jul 19 16:21:33 2023 +0000

        Squash transliterator-parser

        structure for transliterator parser

        start parsing ':: ... ;' rules

        complete ::-rule parsing

        add more global filter tests

        add negative tests for '::'-rules, be more restrictive

        update error docs

        add comment about static UnicodeSet type alias

        add variable defs

        escaping and fix unicodeset handling

        fix unicodeset tests

        function calls

        add variable-inside-unicodesets

        update tests

        rewrite parse_section using parse_element

        fix unquoted literal handling

        add cursor/placeholder tests

        add cursor support

        add allow(unused) for this PR

        remove unused dependencies

        add todo about inefficient unicodeset variablemap handling

        allow usage of UnicodeSet's VariableMap directly in TransliteratorParser

        avoid one allocation per parsed unicodeset

        remove done todo about allocation-free unicodeset parser hook

        avoid allocations for number parsing

        invalid num err with offset

        update comment

        switch to allocation free hex parsing (and support for multi escapes)

        fix main merge conflict

        support \p unicodesets

        remove todo for \p unicodeset parsing

        turn low-prio todo about avoiding clones into note

        turn non-memory-safety safety comments into regular comments

        add issue number to TODOs

        add transliteration component crate
skius added a commit to skius/icu4x that referenced this pull request Aug 10, 2023
@skius
Squash of transliterator-datastruct-generation
c6505b6 
commit 1145a17
Author: Niels Saurer <[email protected]>
Date:   Thu Aug 10 02:06:46 2023 +0200

    Squash merge transliterator-ir

    commit 9d55038
    Author: Niels Saurer <[email protected]>
    Date:   Thu Aug 10 02:03:34 2023 +0200

        fix push_front/push_back mixup

    commit dc8dda7
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 23:02:10 2023 +0200

        remove empty line

    commit bfe5827
    Merge: c85e861 f549131
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 20:57:11 2023 +0200

        Merge branch 'main' into transliterator-ir

    commit c85e861
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:40:53 2023 +0200

        borrow SingleID

    commit 06425a1
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:22:03 2023 +0200

        fix comment indentation

    commit 2f70922
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:09:13 2023 +0200

        update comments

    commit 47444ee
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:06:43 2023 +0200

        fmt

    commit c0de3a0
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:03:19 2023 +0200

        fix clippy, allow testing of intermediate pass1 values

    commit 227f738
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:55:53 2023 +0200

        fix compile errors by introducing 2 small clones per transliterator

    commit 512b158
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:49:01 2023 +0200

        doesn't compile - missing self deconstruction

    commit 7848f09
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:40:51 2023 +0200

        use rule group aggregation in pass1

    commit 93663e4
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:09:29 2023 +0200

        add rule group aggregation

    commit 57666eb
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 14:12:19 2023 +0200

        Squash of transliterator-compiler

        commit d1812b4
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 13:31:53 2023 +0200

            fix merge mistake

        commit f15f6eb
        Merge: abb91cc a39cfed
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 13:27:08 2023 +0200

            Merge branch 'main' into transliterator-compiler

        commit abb91cc
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 01:12:13 2023 +0200

            reformat tests

        commit f6a10f5
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 00:30:09 2023 +0200

            sizes => counts

        commit 9ffc2f0
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 00:26:27 2023 +0200

            add more docs

        commit eae5748
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:46:20 2023 +0200

            remove TODO

        commit 6b09689
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:28:42 2023 +0200

            improve docs

        commit c9b16d5
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:15:23 2023 +0200

            clippy

        commit 020a677
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 22:53:14 2023 +0200

            add result aggregation to first pass

        commit 2d1bfd7
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 16:28:23 2023 +0200

            add tests

        commit 6f35ea5
        Author: Niels Saurer <[email protected]>
        Date:   Mon Aug 7 22:25:56 2023 +0200

            CI fixes

        commit c6c4844
        Author: Niels Saurer <[email protected]>
        Date:   Sun Aug 6 20:06:31 2023 +0200

            first steps

        commit fb68218
        Author: Niels Saurer <[email protected]>
        Date:   Wed Jul 19 16:21:33 2023 +0000

            Squash transliterator-parser

            structure for transliterator parser

            start parsing ':: ... ;' rules

            complete ::-rule parsing

            add more global filter tests

            add negative tests for '::'-rules, be more restrictive

            update error docs

            add comment about static UnicodeSet type alias

            add variable defs

            escaping and fix unicodeset handling

            fix unicodeset tests

            function calls

            add variable-inside-unicodesets

            update tests

            rewrite parse_section using parse_element

            fix unquoted literal handling

            add cursor/placeholder tests

            add cursor support

            add allow(unused) for this PR

            remove unused dependencies

            add todo about inefficient unicodeset variablemap handling

            allow usage of UnicodeSet's VariableMap directly in TransliteratorParser

            avoid one allocation per parsed unicodeset

            remove done todo about allocation-free unicodeset parser hook

            avoid allocations for number parsing

            invalid num err with offset

            update comment

            switch to allocation free hex parsing (and support for multi escapes)

            fix main merge conflict

            support \p unicodesets

            remove todo for \p unicodeset parsing

            turn low-prio todo about avoiding clones into note

            turn non-memory-safety safety comments into regular comments

            add issue number to TODOs

            add transliteration component crate

commit 208abd7
Author: Niels Saurer <[email protected]>
Date:   Thu Aug 10 02:02:23 2023 +0200

    add data struct generation tests

commit d1f7e7c
Author: Niels Saurer <[email protected]>
Date:   Thu Aug 10 00:58:50 2023 +0200

    fix debug_assert bug

commit 1f5c8dd
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 23:25:17 2023 +0200

    refactor pass2 slightly

commit ae14cdc
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 21:04:38 2023 +0200

    clippy

commit 8a14e3e
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 21:02:28 2023 +0200

    tutorials cargo lock

commit 4256873
Merge: 72cff57 f549131
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 20:56:20 2023 +0200

    Merge branch 'main' into transliterator-datastruct-generation

commit 72cff57
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 20:42:03 2023 +0200

    refactor pass2 interface

commit 8fa4dfd
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 20:31:29 2023 +0200

    skip compilation of cursors on source side, anchors on target side

commit 54b0542
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 19:09:50 2023 +0200

    add comment

commit cba53a7
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 19:04:27 2023 +0200

    fix clippy warnings

commit 2dd2ec8
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 19:01:15 2023 +0200

    fmt

commit 56774fe
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 18:45:22 2023 +0200

    refactor MutVarTable

commit 6176769
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 18:31:18 2023 +0200

    revamp pass2 API

commit f8459c9
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 18:22:47 2023 +0200

    initial final data struct generation

commit d6873b0
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 17:48:41 2023 +0200

    Squash of transliterator-ir

    commit c85e861
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:40:53 2023 +0200

        borrow SingleID

    commit 06425a1
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:22:03 2023 +0200

        fix comment indentation

    commit 2f70922
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:09:13 2023 +0200

        update comments

    commit 47444ee
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:06:43 2023 +0200

        fmt

    commit c0de3a0
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 17:03:19 2023 +0200

        fix clippy, allow testing of intermediate pass1 values

    commit 227f738
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:55:53 2023 +0200

        fix compile errors by introducing 2 small clones per transliterator

    commit 512b158
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:49:01 2023 +0200

        doesn't compile - missing self deconstruction

    commit 7848f09
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:40:51 2023 +0200

        use rule group aggregation in pass1

    commit 93663e4
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 16:09:29 2023 +0200

        add rule group aggregation

    commit 57666eb
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 14:12:19 2023 +0200

        Squash of transliterator-compiler

        commit d1812b4
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 13:31:53 2023 +0200

            fix merge mistake

        commit f15f6eb
        Merge: abb91cc a39cfed
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 13:27:08 2023 +0200

            Merge branch 'main' into transliterator-compiler

        commit abb91cc
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 01:12:13 2023 +0200

            reformat tests

        commit f6a10f5
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 00:30:09 2023 +0200

            sizes => counts

        commit 9ffc2f0
        Author: Niels Saurer <[email protected]>
        Date:   Wed Aug 9 00:26:27 2023 +0200

            add more docs

        commit eae5748
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:46:20 2023 +0200

            remove TODO

        commit 6b09689
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:28:42 2023 +0200

            improve docs

        commit c9b16d5
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 23:15:23 2023 +0200

            clippy

        commit 020a677
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 22:53:14 2023 +0200

            add result aggregation to first pass

        commit 2d1bfd7
        Author: Niels Saurer <[email protected]>
        Date:   Tue Aug 8 16:28:23 2023 +0200

            add tests

        commit 6f35ea5
        Author: Niels Saurer <[email protected]>
        Date:   Mon Aug 7 22:25:56 2023 +0200

            CI fixes

        commit c6c4844
        Author: Niels Saurer <[email protected]>
        Date:   Sun Aug 6 20:06:31 2023 +0200

            first steps

        commit fb68218
        Author: Niels Saurer <[email protected]>
        Date:   Wed Jul 19 16:21:33 2023 +0000

            Squash transliterator-parser

            structure for transliterator parser

            start parsing ':: ... ;' rules

            complete ::-rule parsing

            add more global filter tests

            add negative tests for '::'-rules, be more restrictive

            update error docs

            add comment about static UnicodeSet type alias

            add variable defs

            escaping and fix unicodeset handling

            fix unicodeset tests

            function calls

            add variable-inside-unicodesets

            update tests

            rewrite parse_section using parse_element

            fix unquoted literal handling

            add cursor/placeholder tests

            add cursor support

            add allow(unused) for this PR

            remove unused dependencies

            add todo about inefficient unicodeset variablemap handling

            allow usage of UnicodeSet's VariableMap directly in TransliteratorParser

            avoid one allocation per parsed unicodeset

            remove done todo about allocation-free unicodeset parser hook

            avoid allocations for number parsing

            invalid num err with offset

            update comment

            switch to allocation free hex parsing (and support for multi escapes)

            fix main merge conflict

            support \p unicodesets

            remove todo for \p unicodeset parsing

            turn low-prio todo about avoiding clones into note

            turn non-memory-safety safety comments into regular comments

            add issue number to TODOs

            add transliteration component crate

    commit a39cfed
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 13:19:28 2023 +0200

        Add Parsing for Rule-Based Transliterators (unicode-org#3730)

    commit 57e9d59
    Author: Andrew Cupps <[email protected]>
    Date:   Tue Aug 8 18:53:26 2023 -0700

        Resolve follow-up comments to unicode-org#3760 (unicode-org#3818)

        * Docs for `U` and `r`

        * Delete empty test and add todo

        * Remove old code and empty era check

        * Add todo

commit c55c641
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 02:36:53 2023 +0200

    wip

commit c6cbb0a
Author: Niels Saurer <[email protected]>
Date:   Wed Aug 9 01:20:08 2023 +0200

    Squash of transliterator-compiler

    commit abb91cc
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 01:12:13 2023 +0200

        reformat tests

    commit f6a10f5
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 00:30:09 2023 +0200

        sizes => counts

    commit 9ffc2f0
    Author: Niels Saurer <[email protected]>
    Date:   Wed Aug 9 00:26:27 2023 +0200

        add more docs

    commit eae5748
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:46:20 2023 +0200

        remove TODO

    commit 6b09689
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:28:42 2023 +0200

        improve docs

    commit c9b16d5
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 23:15:23 2023 +0200

        clippy

    commit 020a677
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 22:53:14 2023 +0200

        add result aggregation to first pass

    commit 2d1bfd7
    Author: Niels Saurer <[email protected]>
    Date:   Tue Aug 8 16:28:23 2023 +0200

        add tests

    commit 6f35ea5
    Author: Niels Saurer <[email protected]>
    Date:   Mon Aug 7 22:25:56 2023 +0200

        CI fixes

    commit c6c4844
    Author: Niels Saurer <[email protected]>
    Date:   Sun Aug 6 20:06:31 2023 +0200

        first steps

    commit fb68218
    Author: Niels Saurer <[email protected]>
    Date:   Wed Jul 19 16:21:33 2023 +0000

        Squash transliterator-parser

        structure for transliterator parser

        start parsing ':: ... ;' rules

        complete ::-rule parsing

        add more global filter tests

        add negative tests for '::'-rules, be more restrictive

        update error docs

        add comment about static UnicodeSet type alias

        add variable defs

        escaping and fix unicodeset handling

        fix unicodeset tests

        function calls

        add variable-inside-unicodesets

        update tests

        rewrite parse_section using parse_element

        fix unquoted literal handling

        add cursor/placeholder tests

        add cursor support

        add allow(unused) for this PR

        remove unused dependencies

        add todo about inefficient unicodeset variablemap handling

        allow usage of UnicodeSet's VariableMap directly in TransliteratorParser

        avoid one allocation per parsed unicodeset

        remove done todo about allocation-free unicodeset parser hook

        avoid allocations for number parsing

        invalid num err with offset

        update comment

        switch to allocation free hex parsing (and support for multi escapes)

        fix main merge conflict

        support \p unicodesets

        remove todo for \p unicodeset parsing

        turn low-prio todo about avoiding clones into note

        turn non-memory-safety safety comments into regular comments

        add issue number to TODOs

        add transliteration component crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@sffc sffc sffc approved these changes

@robertbastian robertbastian Awaiting requested review from robertbastian

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

@gregtatum gregtatum Awaiting requested review from gregtatum

@nordzilla nordzilla Awaiting requested review from nordzilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up #3760
3 participants
@atcupps @sffc @Manishearth