Removing leading :: from databake expressions
#3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
zbraniecki,
nciric,
gregtatum,
nordzilla,
echeran and
a team
as code owners
robertbastian
removed request for
zbraniecki,
echeran,
gregtatum,
nciric and
nordzilla
This comment was marked as spam.
This comment was marked as spam.
Manishearth
approved these changes
May 25, 2023
sffc
reviewed
May 25, 2023
There was a problem hiding this comment.
Praise: Thanks for making a single atomic change.
Although I have raised concerns about using crate imports in this way in the past, for databake specifically, I think it makes sense to allow imports in this way because it may actually be desirable to perform renames on the modules used by databake.
sffc
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put these in to avoid the outer scope redefining crates, but for #2743 we actually need this functionality.
#2945