Make minor docs changes for 1.2 release #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeran
requested review from
nordzilla,
robertbastian and
a team
as code owners
echeran
requested review from
sffc and
Manishearth
and removed request for
a team,
robertbastian and
nordzilla
|
You need to run |
Manishearth
approved these changes
Apr 13, 2023
sffc
reviewed
Apr 20, 2023
| @@ -49,8 +49,7 @@ As with time zone IDs, there are two interchangeable forms: | |||
| ICU4X uses the short form. | |||
|
|
|||
| Note: in ICU4X, "metazone" is one word and "time zone" is two words, except for this crate | |||
| and module name, where "timezone" is used with no separators. See | |||
| <https://github.com/unicode-org/icu4x/issues/2507>. | |||
There was a problem hiding this comment.
Question: Why did you remove the link? Removing cross-references seems like a regression to me.
| @@ -120,7 +120,7 @@ impl TryFrom<u32> for MirroredPairedBracketData { | |||
| } | |||
|
|
|||
| /// A closed Rust enum representing a closed set of the incoming Bidi_Paired_Bracket_Type | |||
| /// property values necessary in the internal representation of [`MirroredPairedBracketData`] | |||
| /// property values necessary in the internal representation of `MirroredPairedBracketData` | |||
There was a problem hiding this comment.
Question: why did you remove the link?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.