Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasmer to 3.1.1 #3241

Closed
Razican opened this issue Mar 31, 2023 · 4 comments · Fixed by #4621
Closed

Update wasmer to 3.1.1 #3241

Razican opened this issue Mar 31, 2023 · 4 comments · Fixed by #4621
Assignees
Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt

Comments

@Razican
Copy link

Razican commented Mar 31, 2023

It turns out that icu_codepointtrie_builder depends on wasmer 2.2.1, which in its dependency tree contains the mach dependency. This dependency is no longer maintained, as it can be seen in the below advisory.

The good news is that wasmer 3.1.1 no longer depends on mach, so an update of the dependency should solve the issue.


mach is unmaintained

Details
Status unmaintained
Package mach
Version 0.3.2
URL fitzgen/mach#63
Date 2020-07-14

Last release was almost 4 years ago.

Maintainer(s) seem to be completely unreachable.

Possible Alternative(s)

These may or may not be suitable alternatives and have not been vetted in any way;

See advisory page for additional details.

@sffc
Copy link
Member

sffc commented Apr 1, 2023

@Razican Would you like to make a PR for this?

@Razican
Copy link
Author

Razican commented Apr 1, 2023

@Razican Would you like to make a PR for this?

I was trying to do the PR yesterday, but since I'm not familiar with ICU and washer, I didn't know how to migrate the compile errors

The new version doesn't have some features used by ICU4x, but it seems it now can use other crates to implement the required compilers and engines.

@sffc sffc added C-unicode Component: Props, sets, tries T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) labels Apr 20, 2023
@robertbastian
Copy link
Member

Wasmer 3.1.1 doesn't even build for me. It's also broken on docs.rs, and in fact still seems to pull in mach.

@robertbastian robertbastian changed the title RUSTSEC-2020-0168: mach is unmaintained Update wasmer to 3.1.1 May 3, 2023
@robertbastian
Copy link
Member

All we can do here is update wasmer, although that doesn't seem to remove the dependency (#3367 (comment))

@robertbastian robertbastian assigned pdogr and unassigned robertbastian May 3, 2023
sffc added a commit that referenced this issue Feb 27, 2024
Fixes #3241 

I switched our WASM engine to `wasmi` because it is faster to compile
and has fewer dependencies. I changed how we interact with C++, too, in
order to improve the performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants