Be semver safe for icu_capi/test_provider (#3833)

unicode-org · Aug 10, 2023 · c619df8 · c619df8
1 parent b18da77
commit c619df8
Show file tree

Hide file tree

Showing 12 changed files with 24 additions and 26 deletions.
diff --git a/ffi/diplomat/Cargo.toml b/ffi/diplomat/Cargo.toml
@@ -65,7 +65,7 @@ logging = ["icu_provider/logging", "dep:log"]
 simple_logger = ["dep:simple_logger", "logging"]
 
 # Legacy features
-provider_test = []
+provider_test = ["compiled_data"]
 cpp_default = ["logging"]
 wasm_default = ["logging"]
 

diff --git a/ffi/diplomat/cpp/docs/source/locale_ffi.rst b/ffi/diplomat/cpp/docs/source/locale_ffi.rst
diff --git a/ffi/diplomat/cpp/docs/source/provider_ffi.rst b/ffi/diplomat/cpp/docs/source/provider_ffi.rst
diff --git a/ffi/diplomat/cpp/include/ICU4XDataProvider.hpp b/ffi/diplomat/cpp/include/ICU4XDataProvider.hpp
diff --git a/ffi/diplomat/cpp/include/ICU4XLocale.hpp b/ffi/diplomat/cpp/include/ICU4XLocale.hpp
diff --git a/ffi/diplomat/js/docs/source/locale_ffi.rst b/ffi/diplomat/js/docs/source/locale_ffi.rst
diff --git a/ffi/diplomat/js/docs/source/provider_ffi.rst b/ffi/diplomat/js/docs/source/provider_ffi.rst
diff --git a/ffi/diplomat/js/include/ICU4XDataProvider.d.ts b/ffi/diplomat/js/include/ICU4XDataProvider.d.ts
diff --git a/ffi/diplomat/js/include/ICU4XLocale.d.ts b/ffi/diplomat/js/include/ICU4XLocale.d.ts
diff --git a/ffi/diplomat/src/datetime_formatter.rs b/ffi/diplomat/src/datetime_formatter.rs
@@ -25,8 +25,6 @@ pub mod ffi {
     #[diplomat::opaque]
     /// An ICU4X TimeFormatter object capable of formatting an [`ICU4XTime`] type (and others) as a string
     #[diplomat::rust_link(icu::datetime::TimeFormatter, Struct)]
-    // TODO(#2153) - Rename to ICU4XTimeFormatter when we remove the dependency on calendar
-    // from TimeFormatter.
     pub struct ICU4XTimeFormatter(pub TimeFormatter);
 
     #[diplomat::enum_convert(length::Time, needs_wildcard)]

diff --git a/ffi/diplomat/src/locale.rs b/ffi/diplomat/src/locale.rs
@@ -185,20 +185,20 @@ pub mod ffi {
             self.0.strict_cmp(other).into()
         }
 
-        /// Unconditionally panics.
+        /// Deprecated
         ///
         /// Use `create_from_string("en").
         #[cfg(feature = "provider_test")]
         pub fn create_en() -> Box<ICU4XLocale> {
-            unimplemented!()
+            Box::new(ICU4XLocale(icu_locid::locale!("en")))
         }
 
-        /// Unconditionally panics.
+        /// Deprecated
         ///
         /// Use `create_from_string("bn").
         #[cfg(feature = "provider_test")]
         pub fn create_bn() -> Box<ICU4XLocale> {
-            unimplemented!()
+            Box::new(ICU4XLocale(icu_locid::locale!("bn")))
         }
     }
 }

diff --git a/ffi/diplomat/src/provider.rs b/ffi/diplomat/src/provider.rs
@@ -75,15 +75,15 @@ pub mod ffi {
             )))
         }
 
-        /// Unconditionally panics.
+        /// Deprecated
         ///
-        /// It used to provide a test data provider, but has been superseded by `create_compiled`.
+        /// Use `create_compiled()`.
         #[cfg(all(
             feature = "provider_test",
             any(feature = "any_provider", feature = "buffer_provider")
         ))]
         pub fn create_test() -> Box<ICU4XDataProvider> {
-            unimplemented!()
+            Self::create_compiled()
         }
 
         /// Constructs a `BlobDataProvider` and returns it as an [`ICU4XDataProvider`].