ICU-20859 ICU4C: Python data build uses wrong value for tool_cfg #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelandrejs
approved these changes
Oct 10, 2019
daniel-ju
approved these changes
Oct 10, 2019
mihnita
added a commit
to mihnita/icu
that referenced
this pull request
Sep 18, 2024
- Matching PR unicode-org#883 in the message-format-wg repo. - Also removes some unused imports
7 tasks
mihnita
added a commit
that referenced
this pull request
Sep 18, 2024
- Matching PR #883 in the message-format-wg repo. - Also removes some unused imports
catamorphism
added a commit
to catamorphism/icu
that referenced
this pull request
Sep 19, 2024
Matching PR unicode-org#883 in the message-format-wg repo. Also move spec tests for unsupported statements and expressions into new files to serve as syntax error tests.
catamorphism
added a commit
to catamorphism/icu
that referenced
this pull request
Sep 20, 2024
Matching PR unicode-org#883 in the message-format-wg repo. Also move spec tests for unsupported statements and expressions into new files to serve as syntax error tests.
catamorphism
added a commit
to catamorphism/icu
that referenced
this pull request
Sep 20, 2024
Matching PR unicode-org#883 in the message-format-wg repo. Also move spec tests for unsupported statements and expressions into new files to serve as syntax error tests.
catamorphism
added a commit
to catamorphism/icu
that referenced
this pull request
Sep 20, 2024
Matching PR unicode-org#883 in the message-format-wg repo. Also move spec tests for unsupported statements and expressions into new files to serve as syntax error tests.
catamorphism
added a commit
that referenced
this pull request
Sep 21, 2024
Matching PR #883 in the message-format-wg repo. Also move spec tests for unsupported statements and expressions into new files to serve as syntax error tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tool_cfgsetting that is passed to the Python data build script should useCFGTOOLSinstead ofCFG.The rest of the
Makedata.makmakefile usesCFGTOOLS, so this is inconsistent.However, this also causes build failures on ARM64 builds when the data file hasn't previously been built (for either x86 or x64). -- (Thanks to Marc Sweetgall for reporting/finding this!).
Checklist