Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22991 Remove unused private fIsSet #3319

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

FrankYFTang
Copy link
Contributor

Remove unused private fIsSet from Calendar to save 24 bytes per Calendar object.

Java removed the isSet field at least 24 years ago.

Checklist

  • Required: Issue filed: ICU-22991
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

This field is removed in Java 24 years ago. Save 24 bytes per Calendar
object.
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    fIsSet[field] = true; // Remove later

“later” is now!

@FrankYFTang FrankYFTang merged commit 841e88b into unicode-org:main Dec 23, 2024
94 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22991-rm-IsTimeSet branch December 23, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants