Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22954 disable TestCharString on Cygwin #3318

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ICU-22954 disable TestCharString on Cygwin #3318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb91088
ICU-22954 disable TestCharString on Cygwin
markusicu Dec 23, 2024
b6f201a
ICU-22954 disable TestCharStrAppendNumber on Cygwin
markusicu Dec 23, 2024
2323612
ICU-22954 disable StringCaseTest::TestCasing() on Cygwin
markusicu Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions icu4c/source/test/intltest/strcase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,8 @@ StringCaseTest::TestCasingImpl(const UnicodeString &input,

void
StringCaseTest::TestCasing() {
// Crashes on Cygwin since ICU-22954 PR #3295, see ICU-22999.
#if U_PLATFORM != U_PF_CYGWIN
UErrorCode status = U_ZERO_ERROR;
#if !UCONFIG_NO_BREAK_ITERATION
LocalUBreakIteratorPointer iter;
Expand Down Expand Up @@ -616,6 +618,7 @@ StringCaseTest::TestCasing() {
dataerrln("UnicodeString::toTitle(nullptr) failed.");
}
#endif
#endif
}

void
Expand Down
6 changes: 6 additions & 0 deletions icu4c/source/test/intltest/strtest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,8 @@ StringTest::TestSTLCompatibility() {

void
StringTest::TestCharString() {
// Crashes on Cygwin since ICU-22954 PR #3295, see ICU-22999.
#if U_PLATFORM != U_PF_CYGWIN
IcuTestErrorCode errorCode(*this, "TestCharString()");
char expected[400];
static const char longStr[] =
Expand Down Expand Up @@ -831,6 +833,7 @@ StringTest::TestCharString() {
s.extract(buffer, 2, errorCode);
assertEquals("abc.extract(2) overflow", U_BUFFER_OVERFLOW_ERROR, errorCode.reset());
}
#endif
}

void
Expand All @@ -843,6 +846,8 @@ StringTest::TestCStr() {
}

void StringTest::TestCharStrAppendNumber() {
// Crashes on Cygwin since ICU-22954 PR #3295, see ICU-22999.
#if U_PLATFORM != U_PF_CYGWIN
IcuTestErrorCode errorCode(*this, "TestCharStrAppendNumber()");

CharString testString;
Expand Down Expand Up @@ -870,6 +875,7 @@ void StringTest::TestCharStrAppendNumber() {
testString.clear();
testString.appendNumber(0, errorCode);
assertEquals("TestAppendNumber when appending zero", "0", testString.data());
#endif
}

void
Expand Down