Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22920 Fix raw type warnings in icu4j tests: charset, common_tests, translit #3309

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ICU-22920 Fix raw type warnings in icu4j tests: charset, common_tests, translit #3309

merged 1 commit into from
Dec 18, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Dec 17, 2024 •
edited
Loading

Removes 472 warnings

Checklist

  • Required: Issue filed: ICU-22920
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested review from echeran and markusicu December 17, 2024 04:01
markusicu
markusicu previously approved these changes Dec 17, 2024
View reviewed changes
icu4j/main/charset/src/test/java/com/ibm/icu/dev/test/charset/TestCharset.java Outdated
SortedMap map = Charset.availableCharsets();
Set keySet = map.keySet();
Iterator iter = keySet.iterator();
SortedMap<String,Charset> map = Charset.availableCharsets();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add space after comma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (which, of course, nullifies the approval :-)

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita merged commit ba012a7 into unicode-org:main Dec 18, 2024
15 checks passed
@mihnita
Copy link
Contributor Author

mihnita commented Dec 18, 2024

Thank you,
M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihnita @markusicu