ICU-22922 BRS 77 Integrate CLDR 46.1 beta1 to ICU main #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
requested review from
srl295,
macchiati,
markusicu and
DraganBesevic
|
/azp run CI-Exhaustive |
|
No pipelines are associated with this pull request. |
We no longer use Azure. Please trigger the exhaustive tests like this: I went to https://github.com/pedberg-icu/icu/actions/workflows/icu_exhaustive_tests.yml but I don't get the workflow trigger. I assume that only you can do so in your fork. |
|
PS: I also removed the TODOs from the PR description. |
Thanks, I have done that, seems to be running: https://github.com/pedberg-icu/icu/actions/workflows/icu_exhaustive_tests.yml But the integration instructions at https://unicode-org.github.io/icu/processes/cldr-icu.html (which I was following) still mention using |
pedberg-icu
commented
Dec 9, 2024
| @@ -151,6 +151,7 @@ mass ; ton ; kilogram ; 907.18474 * x ; 907184.7 | |||
| mass ; tonne ; kilogram ; 1,000 * x ; 1000000.0 | |||
| mass ; earth-mass ; kilogram ; 5,972,200,000,000,000,000,000,000 * x ; 5.9722E27 | |||
| mass ; solar-mass ; kilogram ; 1,988,470,000,000,000,000,000,000,000,000 * x ; 1.98847E33 | |||
| night-duration ; night ; night ; 1 * x ; 1,000.00 | |||
There was a problem hiding this comment.
This had been manually removed in a previous integration and then restored for C but not J, so restoring it here.
pedberg-icu
commented
Dec 9, 2024
| @@ -187,6 +188,7 @@ speed ; kilometer-per-hour ; meter-per-second ; 2.5/9 * x ; 277.7778 | |||
| speed ; mile-per-hour ; meter-per-second ; 0.44704 * x ; 447.04 | |||
| speed ; knot ; meter-per-second ; 4.63/9 * x ; 514.4444 | |||
| speed ; meter-per-second ; meter-per-second ; 1 * x ; 1,000.00 | |||
| speed ; light-speed ; meter-per-second ; 299,792,458 * x ; 2.997925E11 | |||
There was a problem hiding this comment.
This had been manually removed in a previous integration and then restored for C but not J, so restoring it here.
|
part 2 & 3 changes lgtm |
|
waiting for |
|
There is an icu4c exhaustive test failure in RBBITest::TestMonkey which seems to have nothing to do with any CLDR 46.1 changes. I will file a ticket and try to create a logKnownIssue test skip for this: |
@eggrobin please take a look...
ok |
|
The ticket for the RBBITest::TestMonkey failure is https://unicode-org.atlassian.net/browse/ICU-22986 I will also run the exhaustive tests on the main branch to see if the error repros there @markusicu @eggrobin Actually exhaustive tests on the main branch were run 3 days ago and show the same problem: https://github.com/unicode-org/icu/actions/runs/12209763924/job/34064998555 So not related to this PR, we can go ahead and approve & merge this |
markusicu
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This integrates CLDR 46.1 beta1 to ICU main (note that in main ICU still has version 76, so this keeps the data file using 76). It is in 3 separate commits for ease of review:
portion-per-1e9entries are manually removed fromunitsTest.txttest file inicu4c/source/test/testdata/cldr/units/and `icu4j/main/core/src/test/resources/com/ibm/icu/dev/data/cldr/units/ since the relevant code is not yet ready).This should be merged as 3 separate commits, not squashed.
ALLOW_MANY_COMMITS=true