Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22983 Fix DecimalQuantity::shiftLeft ubsan issue #3286

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Nov 27, 2024

Fix undefined behavior of shifting 64 bits in uint64 type

Checklist

  • Required: Issue filed: ICU-22983
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu markusicu self-assigned this Nov 27, 2024
markusicu
markusicu previously approved these changes Nov 27, 2024
@markusicu
Copy link
Member

Could you please check the Java code?

ICU-22983 Add java tests and comments
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/NumberRegressionTests.java is now changed in the branch
  • icu4j/main/core/src/main/java/com/ibm/icu/impl/number/DecimalQuantity_DualStorageBCD.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

Java comments and tests added. The story about java is more interesting but the solution is the same .

@FrankYFTang FrankYFTang merged commit e025466 into unicode-org:main Nov 28, 2024
101 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22983-shift branch November 28, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants