Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22977 Temp fix for MSVC builds: SkipUWP #3282

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Nov 21, 2024

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22977
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita
Copy link
Contributor Author

mihnita commented Nov 21, 2024

Temporary solution to get a green CI.

To check if we still want to support UWP:

"If you are starting to develop Windows apps, we recommend you consider using the Windows App SDK, and WinUI rather than UWP. Although still supported, UWP is not under active development."

https://learn.microsoft.com/en-us/windows/uwp/get-started/universal-application-platform-guide

If we drop support for UWP then we should also remove the icu4c/source/.../*_uwp.vcxproj files, remove ../allinone/Build.Windows.UWP.ProjectConfiguration.props and update ./docs/userguide/icu4c/build.md

@markusicu markusicu self-assigned this Nov 21, 2024
@mihnita mihnita merged commit 743998d into unicode-org:main Nov 21, 2024
102 checks passed
@mihnita mihnita deleted the mihai_fix_msvc_skipuwp branch December 1, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants