Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22870 Remove ja_JP_TRADITIONAL pattern generator tests #3274

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Nov 20, 2024

Support for obsolete locale ID variants was removed 5 years ago, see ICU-20187.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22870
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested a review from markusicu November 20, 2024 16:09
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rp9-next -- same MSVC failures as in #3270 (comment) which are obviously unrelated to these pull requests. Some kind of MSVC config error? Bad CI system image?

@echeran @mihnita @eggrobin are these MSVC GitHub Actions on a "latest" build image that we could pin to something older that works?

@eggrobin
Copy link
Member

are these MSVC GitHub Actions on a "latest" build image […]?

No, everything is pinned to windows-2022.

@mihnita
Copy link
Contributor Author

mihnita commented Nov 20, 2024

There was an update of the windows-2022 image two days ago that broke quite a few things:
https://github.com/actions/runner-images/issues

I didn't find our failure there, but it does not mean it is not caused by this update. The timing is kind of suspect.

Once I get home I'll see if there is a way to pin it. And if that works I will file a bug against the GitHub runner.

Mihai

@mihnita
Copy link
Contributor Author

mihnita commented Nov 21, 2024

Filed actions/runner-images#11016

It is not possible to force a certain image version.
Apparently the only option seems be to build your own image :-(

@mihnita mihnita requested a review from sven-oly November 21, 2024 21:47
@mihnita mihnita force-pushed the mihai_ja_JP_TRADITIONAL branch from 35231c2 to 81bba49 Compare November 21, 2024 21:49
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita merged commit b54f3f5 into unicode-org:main Nov 21, 2024
102 checks passed
@mihnita mihnita deleted the mihai_ja_JP_TRADITIONAL branch December 1, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants