Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21396 Fix incorrect result shown in the userguide example #3273

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Nov 19, 2024

To check I did a RuleBasedTransliterator.createFromRules with the rules in the userguide.
The result is indeed "acks".

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21396
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested review from echeran and markusicu November 19, 2024 22:15
@markusicu
Copy link
Member

@macchiati @poulsbo FYI

@markusicu markusicu self-assigned this Nov 19, 2024
@poulsbo
Copy link
Contributor

poulsbo commented Nov 19, 2024

Age-old typo? Choice of example is to leverage pronunciation similarity, "ax" ~ "acks".

@mihnita mihnita merged commit f55c499 into unicode-org:main Nov 20, 2024
9 checks passed
@mihnita mihnita deleted the mihai_ICU-21396 branch December 1, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants