ICU-22894 MF2, ICU4J: implements configuring the error handling behavior #3188
Conversation
|
|
||
| // Needs more tests. Ported from the equivalent test in ICU4C | ||
| @Test | ||
| public void testFormatterAPI() { |
There was a problem hiding this comment.
nit (non-blocking, not intended to be acted upon for ICU 76): Ideally, this test would be broken up into 3-4 tests
There was a problem hiding this comment.
ACK.
This is in sync with the C++ test.
Would need to refactor both.
But I really expect to replace it completely with .json files from the WG.
icu4j/main/core/src/main/java/com/ibm/icu/message2/MessageFormatter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/message2/MessageFormatter.java
Outdated
Show resolved
Hide resolved
| @@ -319,6 +367,26 @@ public Builder setPattern(String pattern) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the {@link ErrorHandlingBehavior} to use when encountering errors at formatting time. | |||
There was a problem hiding this comment.
Can you refer back to the comment on ErrorHandlingBehavior so as to avoid duplicating this text?
There was a problem hiding this comment.
Removed the duplicated paragraph.
The first paragraph already contains a link to ErrorHandlingBehavior which contains more info.
|
Implemented all, I didn't squash, for visibility. Thank you both! |
mihnita
force-pushed
the
mihai_mf2_icu4j_errors
branch
from
25840d6 to
fbbbc73
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Implements the decision at unicode-org/message-format-wg#879
Checklist