-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22261 Add UCONFIG_NO_MF2 flag that can be used to disable MessageFormat 2 functionality #2931
Conversation
I don't think I have the ability to request reviewers, but paging @markusicu @echeran I'm also not sure if I should file a separate bug for this. (I just used the same bug number as in #2579 for now.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't actually test to make sure this works, but it looks good.
Are there MF2 tests in cintltst
? If so, they should probably have this guard around them as well.
No, only in |
I thought you also had C API, and it'd probably be good to do at least a superficial set of tests to make sure your C wrappers do call through appropriately to the C++ implementation. But I definitely wouldn't ask you to do that now, and since you don't have anything there now, I think you're good to go. :-) |
Ah, no -- no C API yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm please squash
…Format 2 functionality
ac0cb3f
to
dd90918
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
This is a followup to #2579 that adds a compile-time flag to disable the MessageFormat 2 functionality.
Checklist