Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22666 Update ML model to improve Japanese phrase breaking quality #2833

Closed
wants to merge 1 commit into from
Closed

ICU-22666 Update ML model to improve Japanese phrase breaking quality #2833

wants to merge 1 commit into from

Conversation

tushuhei
Copy link
Contributor

@tushuhei tushuhei commented Feb 19, 2024 •
edited by FrankYFTang
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22666
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@tushuhei tushuhei mentioned this pull request Feb 19, 2024
Merged
@markusicu markusicu self-requested a review February 29, 2024 17:09
FrankYFTang
FrankYFTang approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@FrankYFTang FrankYFTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankYFTang
Copy link
Contributor

Please git commit --amend your commit to start with ICU-22666 . Otherwise github won't let you merge . I cannot do that for you.

@tushuhei tushuhei closed this Mar 3, 2024
@tushuhei
Copy link
Contributor Author

tushuhei commented Mar 3, 2024

@FrankYFTang Sorry, it seems I run a wrong command and mistakenly closed this PR, which I cannot reopen anymore.
I made another PR at #2861 with the same change. I hope this works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYFTang FrankYFTang FrankYFTang approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@FrankYFTang FrankYFTang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @FrankYFTang