Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22532 Remove redundant 'void' from empty C++ parameter lists #2745

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

roubert
Copy link
Member

@roubert roubert commented Dec 14, 2023

Follow-up to PR #2744, we might as well be consistent about this.

https://releases.llvm.org/16.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize/redundant-void-arg.html

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22532
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang
Copy link
Contributor

Could you point out how you generate this PR by tool so we can learn from that and use it for other thing.

@roubert
Copy link
Member Author

roubert commented Dec 19, 2023

Could you point out how you generate this PR by tool so we can learn from that and use it for other thing.

The core of it was this:

$ clang-tidy --fix --header-filter='.' --checks='-*,modernize-redundant-void-arg'

(In the future, I intend to add information about Clang-Tidy to the ICU documentation, with instructions on how to create an LLVM compilation database and so on, including a default configuration in the ICU source code repository.)

@roubert roubert merged commit 1384d9f into unicode-org:main Dec 19, 2023
94 checks passed
@roubert roubert deleted the 22532-void branch December 19, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants