Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22605 Exclude the data files from the -sources.jar #2743

Merged
merged 1 commit into from
Dec 15, 2023
Merged

ICU-22605 Exclude the data files from the -sources.jar #2743

merged 1 commit into from
Dec 15, 2023

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Dec 14, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22605
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/pom.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx

@yumaoka any comments?

@mihnita mihnita merged commit e76094c into unicode-org:main Dec 15, 2023
37 checks passed
@mihnita mihnita deleted the mihai_sources_jar_without_data branch December 15, 2023 23:02
@mihnita mihnita mentioned this pull request Sep 27, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@yumaoka yumaoka

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihnita @markusicu @yumaoka