Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21032 Backport to 64 of ICU-20958 #1155

Merged
merged 1 commit into from
May 26, 2020

Conversation

srl295
Copy link
Member

@srl295 srl295 commented May 26, 2020

ICU-21032 Backport to 64.x: ICU-20958 Prevent SEGV_MAPERR in append

See #971

(cherry picked from commit b7d08bc)

@srl295 srl295 added the cherry-pick This PR is a cherry-pick of an already-approved-and-merged PR to another branch. label May 26, 2020
@srl295 srl295 self-assigned this May 26, 2020
@srl295
Copy link
Member Author

srl295 commented May 26, 2020

/azp run CI-Exhaustive

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@srl295
Copy link
Member Author

srl295 commented May 26, 2020

@jefgen on the CI-J (Which isn't relevant for this)

##[error]The job running on agent Hosted Agent ran longer than the maximum time of 20 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

@srl295 srl295 merged commit 18b212f into unicode-org:maint/maint-64 May 26, 2020
@srl295 srl295 deleted the backport-64-20958 branch May 26, 2020 19:58
@jefgen
Copy link
Member

jefgen commented May 26, 2020

@jefgen on the CI-J (Which isn't relevant for this)

##[error]The job running on agent Hosted Agent ran longer than the maximum time of 20 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

It looks like both Azure Pipelines and Travis have the same error/issue with the ICU4J builds:

[ivy:retrieve] :::: ERRORS
[ivy:retrieve] 	SERVER ERROR: HTTPS Required url=http://repo1.maven.org/maven2/junit/junit/4.12/junit-4.12.pom
[ivy:retrieve] 	SERVER ERROR: HTTPS Required url=http://repo1.maven.org/maven2/junit/junit/4.12/junit-4.12.jar
[ivy:retrieve] 	SERVER ERROR: HTTPS Required url=http://repo1.maven.org/maven2/pl/pragmatists/JUnitParams/1.0.5/JUnitParams-1.0.5.pom
[ivy:retrieve] 	SERVER ERROR: HTTPS Required url=http://repo1.maven.org/maven2/pl/pragmatists/JUnitParams/1.0.5/JUnitParams-1.0.5.jar
[ivy:retrieve] 

IIRC, this is actually ICU-20942, which I fixed with #965 (in 66.1).

I suppose if we wanted to get the ICU4J CI builds working in the maint/maint-66 branch then we could cherry-pick that into 64.1 too, but since this change is only for ICU4C, perhaps it's not worth it.

@srl295
Copy link
Member Author

srl295 commented May 26, 2020

OK, probably should backport 20942 at some point… good to know thanks

richardlau added a commit to richardlau/node-1 that referenced this pull request May 27, 2020
Add floating patch for ICU 64.2 from unicode-org/icu@18b212f.

Original commit message:
    ICU-21032 Backport to 64.x: ICU-20958 Prevent SEGV_MAPERR in append

    See nodejs#971

    (cherry picked from commit b7d08bc04a4296982fcef8b6b8a354a9e4e7afca)

Refs: https://unicode-org.atlassian.net/browse/ICU-20958
Refs: unicode-org/icu#1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick This PR is a cherry-pick of an already-approved-and-merged PR to another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants