Skip to content

Commit

Permalink
Implemented review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mihnita committed Dec 7, 2024
1 parent dd81937 commit 0448e8f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
9 changes: 8 additions & 1 deletion docs/processes/release/tasks/versions.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,14 @@ need to be correspondingly updated. See below for more files to be updated and s
[icu4c/source/data/misc/icuver.txt](https://github.com/unicode-org/icu/blob/main/icu4c/source/data/misc/icuver.txt)
needs to be updated with the correct version number for ICU and its data.

#### Since ICU 68, but before ICU 77
#### Since ICU 77

The tool takes the `icuVersion` and `icuDataVersion` from the official ICU APIs.
(from the icu4j listed as a dependency of the tool, usually the one you just built from the `icu4j` folder).

If you need values different than that, you can specify them as the command line parameters (`--icuVersion` and `--icuDataVersion`).

#### Since ICU 68

In
[tools/cldr/cldr-to-icu/build-icu-data.xml](https://github.com/unicode-org/icu/blob/main/tools/cldr/cldr-to-icu/build-icu-data.xml)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,10 @@ private void generate() {
}
}

private void run(String[] args) {
options.processArgs(args);
clean();
generate();
}

public static void main(String[] args) {
new Cldr2Icu().run(args);
Cldr2Icu self = new Cldr2Icu();
self.options.processArgs(args);
self.clean();
self.generate();
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// © 2019 and later: Unicode, Inc. and others.
// © 2024 and later: Unicode, Inc. and others.
// License & terms of use: http://www.unicode.org/copyright.html
package org.unicode.icu.tool.cldrtoicu.ant;

Expand Down

0 comments on commit 0448e8f

Please sign in to comment.