Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17295 tz2023d data updates and cleaned up deprecated zones/metazone #3442

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

yumaoka
Copy link
Member

@yumaoka yumaoka commented Jan 8, 2024

CLDR-17295

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@yumaoka yumaoka requested a review from macchiati January 8, 2024 17:57
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCoverageLevel.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@yumaoka yumaoka requested a review from sffc January 8, 2024 19:15
@yumaoka
Copy link
Member Author

yumaoka commented Jan 8, 2024

@macchiati I found we did not update tzdata files in CLDR tools recently. 2023 was a quiet year for TZ database, and I guess we probably did not need to touch metazone. In CLDR 44, we deprecated some CLDR canonical time zones to match IANA zone.tab. Because we use canonical zone IDs as keys for zone display names and exemplar city names, locale data for deprecated canonical zone ID are no longer used. These names (e.g. exemplar city name for America/Yellowknife) are now just redundant. I noticed this when I run one of unit test case after importing the latest zone.tab to CLDR code base. So this PR contains removal of locale data for obsolete canonical zone IDs.

@yumaoka
Copy link
Member Author

yumaoka commented Jan 8, 2024

@sffc Related to previous comment, TZ database folks concluded America/Santa_Isabel was not really required. CLDR created metazone Mexico_Northwest, but it turned out we really don't need this, because America/Santa_Isabel is in same zone with America/Tijuana. America/Santa_Isabel is removed from zone.tab a while ago. So metazone Mexico_Northwest was just introduced by the misunderstanding and at this point, it should not be used at all.

I removed the metazone Mexico_Northwest from metaZone.xml including the short metazone ID mapping in this PR.

<metazoneId shortId="meno" longId="Mexico_Northwest" />

Could you please check the removal of metazone short ID has no bad impacts in ICU4X implementation?

@yumaoka yumaoka merged commit 57c1f4c into unicode-org:main Jan 11, 2024
10 checks passed
@yumaoka yumaoka deleted the 17295-tz2023d branch January 11, 2024 16:40
@sffc
Copy link
Member

sffc commented Jan 17, 2024

For ICU4X, I believe there is no harm in adding or removing these IDs. It may mean that there are display names that are not reachable with mixed data sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants