Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search for triangle index update to work on mac #424

Merged

Conversation

madsendennis
Copy link
Collaborator

No description provided.

@madsendennis
Copy link
Collaborator Author

This "problem" that some ply formats cannot be read seems only to be a problem on Mac M processors when running a non-aarch64 java version. If changing to an aarch version, there is no problem.

@madsendennis
Copy link
Collaborator Author

I am also able to replicate the problem on another machine (not arm processor) - this MR fixes it.

Copy link
Contributor

@marcelluethi marcelluethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
It is not obvious to me why one of the solution should work and the other not on some systems. But as the new solution is at the same time also more readable, I am happy if it is merged.

@madsendennis madsendennis merged commit 2ed8c7e into unibas-gravis:release-1.0 Jan 29, 2024
2 checks passed
@madsendennis madsendennis deleted the fix/ply-vertex-on-mac branch January 29, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants