Feat/remove vtk from scalismo #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 5, 2024 16:19
added 5 commits
January 22, 2024 16:02
|
Beside moving all VTK dependent functionality out of scalismo, we also move all active shape model code to a separate repository: https://github.com/unibas-gravis/scalismo-asm |
added 2 commits
January 22, 2024 16:25
|
ASM removed from the code and outcommented tests. I already rebased it to be on top of the release-1.0 branch. So I would say that it can be merged in - it does include the decimator that is still under rewriting and with a bug, bug we have a separate MR open for that. We should just not make a RC before that is fixed and tested. |
* feat: native scala version of Fast-Quadric-Mesh-Simplification --------- Co-authored-by: Andreas Morel-Forster <[email protected]>
|
Branch rebased to on top of all the other MRs. Comments also removed from tests as requested by @Andreas-Forster . |
Andreas-Forster
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all VTK dependent functionality from Scalismo. This is mainly IO and format conversion.
Upstream of this branch needs to be reset to main after the pending MRs are merged in. This branch contains the current version of the MRs.
All vtk dependent tests have been moved to scalismo-vtk and commented out in this MR.
Missing: The
gaussianSmoothinghas been commented out fromGaussianGradientImagePreprocessor. We need to find another way to implement this in scalismo.By removing the VTK dependency, a simple scalismo.jar app goes from +700MB to ~40MB.
This is the last part of removing the VTK dependency from Scalismo, #415