Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove vtk dependency to calculate tetrahedron volume #417

Merged
merged 3 commits into from
Jan 22, 2024
Merged

feat: remove vtk dependency to calculate tetrahedron volume #417

merged 3 commits into from
Jan 22, 2024

Conversation

madsendennis
Copy link
Collaborator

Remove vtk dependency to calculate tetrahedron volume.
Part of the steps to move away from VTK, #415

@madsendennis
Copy link
Collaborator Author

I moved the Determinantes object from being private to public. Should I additionally move this to another location? E.g. under geometry? Maybe additionally change the name to: Determinant?

@Andreas-Forster
Copy link
Member

I would vote for moving it to another location. @marcelluethi what do you think? Maybe scalismo.numerics would also be an option?

@madsendennis
Copy link
Collaborator Author

I would vote for moving it to another location. @marcelluethi what do you think? Maybe scalismo.numerics would also be an option?

Good idea. I think scalismo.numerics makes sense as well. I've pushed an update. Then hopefully it is directly ready to merge when Marcel gets time to look over it.

Andreas-Forster
Andreas-Forster approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Andreas-Forster Andreas-Forster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

marcelluethi
marcelluethi approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@marcelluethi marcelluethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@madsendennis madsendennis changed the base branch from main to release-1.0 January 22, 2024 10:37
@madsendennis madsendennis merged commit 7da793f into unibas-gravis:release-1.0 Jan 22, 2024
@madsendennis madsendennis deleted the feat/native-tetrahedron-volume-calculation branch January 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreas-Forster Andreas-Forster Andreas-Forster approved these changes

@marcelluethi marcelluethi marcelluethi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsendennis @Andreas-Forster @marcelluethi