816 layouts for reflexion modeling #824

koschke · 2025-02-12T08:16:22Z

This PR introduces a new nested layout for the reflexion analysis where a user can select one layout for the implementation and another layout for the architecture.

To achieve that, the user needs to select "Reflexion" from node-layout menu. The two new sub-menus show up and the user can select the layout for the implementation and architecture, respectively.

It should be noted that the first and original data path relates to the implementation if "From File" was selected as a node layout for the implementation. The architecture layout data path (the second and new one) relates to the architecture.

To enable that this nested layout, a substantial refactoring of the layouts was necessary.:

All layout calculations now have parameters for the centerpoint and the width and depth of the available area.
There are now no flat node layouts anymore.
The distinction between LocalScale and AbsoluteScale for ILayoutNode does not exist anymore (there was never a distinction).
The ILayoutNode type hierarchy has been simplified.
A NodeTransform is now defined by its center point, no longer by its ground center. This is consistent with Unity and simplifies things.

In addition, the Cose layout was removed. We have never really used it and it was declared as deprecated. Likewise, Manhattan layout was removed. It is not hierarchical and makes little sense. It existed only because it was the very first layout implemented to get things going.

Additional unrelated changes:

GraphReader has now (a very simple) progress report.
Obsolete code in SEECityRandom was finally removed (existed only for a publication).
A bug in EvoStreets was fixed.
Several minor code improvements here and there, such as the use of the simplified new() operator.
Shortened the time for tests waiting for a response from the Axivion Dashboard.
The scene SEENewWorld has changed because the Cose layout was removed.

…ut is selected.

…ure.

…ure. Configured these new parameters.

Added tool tips. Added readonly where possible.

…lexion-modeling # Conflicts: # Assets/SEE/Tools/Livekit/LivekitVideoManager.cs # Packages/packages-lock.json # ProjectSettings/ProjectVersion.txt

…lexion-modeling

…lexion-modeling # Conflicts: # Assets/SEE/Game/City/SEEReflexionCity.cs # Assets/SEE/Game/CityRendering/GraphRenderer.cs # Assets/Scenes/SEENewWorld.unity

All other things are still work in progress.

Removed references to removed Cose Layout. Split ILayoutNode.cs into separate files.

…micTable.

…cation.

No one else is using it.

ILayoutNode has an implementation of IHierarchyNode. AbstractLayoutNode does no longer need the mapping ToLayoutNode. Clients can (and need) to call AddChild to establish the node hierarchy.

The previous implementation let the LoadedNodeLayout fail because the ID was not set. We need to retrieve it from the game objects.

This way the naming is consistent with the edge layouts.

for the layout. The ReflexionLayout needs that.

We have never truly made a distinction.

Should have been architectureArea. Removed debugging code. Removed unecessary prefix System for Exception. Removed obsolete code that was commented out.

github-actions

There are a few bad patterns I found which you should check.

Assets/SEE/Game/City/SEEReflexionCity.cs

Assets/SEE/Layout/NodeLayouts/EvoStreetsNodeLayout.cs

Assets/SEE/Layout/NodeLayouts/ReflexionLayout.cs

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

koschke added 30 commits January 8, 2025 19:18

#816 Settings for incremental tree-map layout shown only if that layo…

42337c8

…ut is selected.

#816 Removed unused imports.

696331e

#816 The user can now select a separate node layout for the architect…

db272d5

…ure.

#816 The user can now select a separate node layout for the architect…

1ce811c

…ure. Configured these new parameters.

#818 Layout for the architecture only.

d5a1d65

Improved documentation. Added more error diagnostics.

f1dec10

Added tool tips. Added readonly where possible.

Updated to Unity version 6000.0.33f1.

8f1a60f

#816 Working on calculating two separate layouts. Work in progress.

9347114

Merge remote-tracking branch 'origin/master' into 816-layouts-for-ref…

13c2ecb

…lexion-modeling # Conflicts: # Assets/SEE/Tools/Livekit/LivekitVideoManager.cs # Packages/packages-lock.json # ProjectSettings/ProjectVersion.txt

Merge remote-tracking branch 'origin/master' into 816-layouts-for-ref…

7b81714

…lexion-modeling

Merge remote-tracking branch 'origin/master' into 816-layouts-for-ref…

7248da6

…lexion-modeling # Conflicts: # Assets/SEE/Game/City/SEEReflexionCity.cs # Assets/SEE/Game/CityRendering/GraphRenderer.cs # Assets/Scenes/SEENewWorld.unity

#816 Re-Draw button only shown when graph is drawn.

611fdb1

#816 More informative exception.

40971f3

#816 We will now wait less for a dashboard response.

6991bf3

#816 Calculating the areas for implmentation and architecture works.

464f675

All other things are still work in progress.

#816 Renamed parameters. Added documentation.

d85fcd6

#816 Improved documentation. Renamed parameter.

217201b

#816 Improved documentation. Removed documentation of removed paramter.

e97c75d

#816 Removed unused import.

5896bbd

#816 Removed unused import.

4b6f477

#816 Improved documentation.

cfc4a3b

#816 Removed Cose Layout.

f60f7df

#816 Changed API of node layouts: rectangle parameter added.

f03704f

Removed references to removed Cose Layout. Split ILayoutNode.cs into separate files.

#816 Removed CoseGraphSettings. Added new table CloneCity. Moved Dyna…

2e15dba

…micTable.

#816 Settings for Network Linux subsystem (clone information).

730aeb8

#816 Removed AddCloneEdges(). Was introduced only for a VISSOFT publi…

4f7afed

…cation.

#816 Simplified new.

c5433c7

#816 Documentation makes clear position and scale are worldspace.

2c778ff

#816 Simplified new.

3e70593

#816 Added Print() for debugging.

6220eb2

koschke added 17 commits February 10, 2025 07:36

#816 Moved IGraphNode.HasType to IGameNode.

88319d5

#816 Removed. Had no purpose anymore.

94e9513

#816 Moved GraphRenderer.ToAbstractLayoutNodes() to EvolutionRenderer.

d63a422

No one else is using it.

#816 Moved HasType to IGameNode region.

e1d7675

#816 Simplified new(). Other very minor code edits.

069d602

#816 Removed unused import.

3ec3a93

#816 Restructured inheritance hierarchy of ILayoutNode.

1df6779

ILayoutNode has an implementation of IHierarchyNode. AbstractLayoutNode does no longer need the mapping ToLayoutNode. Clients can (and need) to call AddChild to establish the node hierarchy.

#816 Removed unused import.

9e54732

#816 Fixed implementation of ID.

8827bb4

The previous implementation let the LoadedNodeLayout fail because the ID was not set. We need to retrieve it from the game objects.

#816 Renamed NodeLayout.GetLayout to Create.

4ca82c6

This way the naming is consistent with the edge layouts.

#816 Fixed indentation.

c0b87ad

#816 Added IHiearchyNode.RemoveChild so that we can modify the hierarchy

fbd3b03

for the layout. The ReflexionLayout needs that.

#816 Fixed x co-ordindate of root NodeTransform. Must be x. Was y.

615bd76

#816 Merged IGameNode.AbsoluteScale and LocalScale into one.

36373ac

We have never truly made a distinction.

#816 Fixed actual parameter to rchitectureLayout.Create.

6c99112

Should have been architectureArea. Removed debugging code. Removed unecessary prefix System for Exception. Removed obsolete code that was commented out.

#816 Removed unused method.

40a3513

#816 The settings for a reflexion layout are now passed to the layout.

6ad2424

koschke linked an issue Feb 12, 2025 that may be closed by this pull request

Different layouts for architecture and implementation in reflexion modeling needed #816

Open

koschke marked this pull request as draft February 12, 2025 08:16

github-actions bot reviewed Feb 12, 2025

View reviewed changes

koschke and others added 7 commits February 12, 2025 09:17

Added suggestion by bot.

3f7e58c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Added suggestion by bot.

f0eb857

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

#816 Added an issue for the FIXME.

f572688

#816 Added documentation.

9ac27c0

#816 Added documentation.

329b090

#816 Added documentation for type parameter.

fca98c2

#816 Added documentation.

0f6df6f

koschke added the enhancement New feature or request label Feb 12, 2025

koschke marked this pull request as ready for review February 12, 2025 09:09

koschke requested a review from Cyclone1337 February 12, 2025 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

816 layouts for reflexion modeling #824

816 layouts for reflexion modeling #824

koschke commented Feb 12, 2025 •

edited

Loading

github-actions bot left a comment

816 layouts for reflexion modeling #824

Are you sure you want to change the base?

816 layouts for reflexion modeling #824

Conversation

koschke commented Feb 12, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

koschke commented Feb 12, 2025 •

edited

Loading