Integrating the functionality to fully create a Reflexion City independently. #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponding dialog. The use of strings for type selection will be improved.
…ig menu for the universal tables. These initally do not have a city component.
…versal tables, not every object with the tag CodeCity has a component of the AbstractSEECity (or subclass).
… selection for the empty table.
…need to be adjusted and made more initial. It's only the first version.
…ettings still need to be made to the types.
…es from the inital config.
…onfigurations from the initial city.
…e initial nodes (soon).
… is on the right and the implementation root is on the left. Additionally, the nodes are scaled so that the architecture root occupies 60% and the implementation 40% of the table.
… being changed. When adding a new node, ensure that a root type cannot be assigned.
…reation. Otherwise, the key was never updated and the metric color was calculated incorrectly. In the future, it must be checked whether additional keys need to be updated.
…ation root if it hasn't been loaded yet. An upload icon has been introduced for this purpose. The loading functionality has not yet been implemented.
koschke
requested changes
Jan 27, 2025
The progressState should not be maintained by the called method CreateReflexionCity() but rather by Update(). One would not expect this kind of side effect for a method named CreateReflexionCity(). Swapping via tuple (suggested by Visual Studio).
…rovement # Conflicts: # Assets/StreamingAssets/SEE/BranchCity.cfg
koschke
requested changes
Jan 28, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…gst/SEE into reflexion-table-improvement
…gst/SEE into reflexion-table-improvement
…ncountered. Otherwise the error message will loop forever.
Improved comments.
koschke
requested changes
Jan 28, 2025
koschke
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the creation of initial reflexion cities, which can then load various implementations or architectures. Alternatively, the architecture can also be created completely independently.
The loaded sub-graphes are merged into a single graph as usual. Additionally, a new NodeType
ROOThas been introduced for the root node of the cities.Sub-roots for the architecture graph receive the type
ARCHITECTUREwhile those for the implementation graph receiveIMPLEMENTATION.Nodes of these types cannot be added again via the
AddNodeaction, and can't changed their type viaEditNode.Therefore, the
Deleteaction for this sub-root-types has been modified toclearthe nodes - this means deleting only their existing children.The colors for these root nodes have also been updated.
The
MetricLevelkey had to be updated inMetricMaximato ensure that dynamically nested nodes are created and displayed correctly without triggering an error. (Previously, new nodes had a higherMetricLevelthan the maximum allowed level, and this was not corrected even when re-triggering the maximum level. Refer to commitd02a97efrom November 1, 2024.)The
RuntimeConfigMenuis rebuilt every time a city is added or deleted.Cities added during runtime are assigned a name to distinguish them in the
RuntimeConfigMenu.To achieve this, the
StringPropertyclass has been enhanced with form validation.It is important to note that the new
CitySelectionManagercomponent must be added to all tables for them to be managed in theRuntimeConfigMenu. This component manages a list of all tables, including their associated cities, which avoids potentially expensiveGameObject.Findcalls.The
Re-Drawfunctionality has also been integrated into theRuntimeConfigMenu.Several smaller fixes were also implemented, such as restoring network functionality for the
Deleteaction and resolving an issue with theContexMenuthat occured due to the XR merge.