Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when moving newly added nodes if mapping has already started in the reflexion city #822

Open
Cyclone1337 opened this issue Jan 22, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Cyclone1337
Copy link
Collaborator

I found a bug that occurs when a new node is added, then mapped some other nodes, and afterward the new node is attempted to be moved.

Steps:

  1. Add a new node (UNKOWNTYPE).
  2. Start mapping from the implementation to the architecture.
  3. Move the node added in Step 1.

Video
https://github.com/user-attachments/assets/fe9e8fe9-f7b6-4e38-83a0-c90f2609549c

Error message:

Reflexion Mapping: Parenting 85ee1e47-53c9-45fa-a430-17cd9ad88329 onto Main failed: Given Edge '(argument.h [File]) --(Source_Dependency)-> (argument.c [File])' must be contained in the Architecture graph!

UnityEngine.Debug:LogError (object)
SEE.UI.Notification.ShowNotification:Error (string,string,single,bool) (at Assets/SEE/UI/Notification/ShowNotification.cs:117)
SEE.Controls.Actions.MoveAction/GrabbedObject:ReflexionMapperSetParent (UnityEngine.GameObject,UnityEngine.GameObject) (at Assets/SEE/Controls/Actions/MoveAction.cs:668)
SEE.Controls.Actions.MoveAction/GrabbedObject:Reparent (UnityEngine.GameObject,bool,bool) (at Assets/SEE/Controls/Actions/MoveAction.cs:605)
SEE.Controls.Actions.MoveAction:Update () (at Assets/SEE/Controls/Actions/MoveAction.cs:173)
SEE.Utils.History.ActionHistory:Update () (at Assets/SEE/Utils/History/ActionHistory.cs:213)
SEE.Controls.Actions.GlobalActionHistory:Update () (at Assets/SEE/Controls/Actions/GlobalActionHistory.cs:23)
SEE.GO.Menu.PlayerMenu:Update () (at Assets/SEE/GameObjects/Menu/PlayerMenu.cs:227)

@Cyclone1337 Cyclone1337 added the bug Something isn't working label Jan 22, 2025
Cyclone1337 added a commit that referenced this issue Feb 14, 2025
The error from #822 occurred because the method AddChildInArchitecture calls the AssertNotRedundant method when checking the incoming edges, which in turn examines an implementation ede in the IsRedundantIn function. This caused an exception to be thrown by the IsSpecified method. By changing the order of the conditions, the IsSpecified method is no longer called, when a implementation edge is examined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant