Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily sync #61

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Daily sync #61

merged 7 commits into from
Jul 17, 2024

Conversation

Zalk0
Copy link
Collaborator

@Zalk0 Zalk0 commented Jun 2, 2024

  • synchro auto fonctionnelle
  • commandes pour l'activer et la désactiver
  • possibilité de la lancer manuellement avec une commande
  • prise en compte que branch_list et branch_level_list peuvent être None

Zalk0 added 2 commits June 2, 2024 15:43
@Zalk0
feat: WIP automatic daily etu sync
364871c 
spaghetti code to improve later
isn't tested
@Zalk0
feat: auto sync is working
461815f 
- commands are done
- branch_list and branch_level_list can be None
@Zalk0 Zalk0 requested a review from imperosol June 2, 2024 15:58
Zalk0
Zalk0 commented Jun 2, 2024
View reviewed changes
Copy link
Collaborator Author

@Zalk0 Zalk0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 points où j'aimerai un avis

data/discord.example.toml
@@ -14,6 +14,7 @@ id = 1234567891234567890
# Channel where the bot sends info about his status and admins will use commands to manage the server
channel_admin_id = 1234567891234567890
invite_link = "https://discord.gg/<replace me>"
etu_sync = true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suis pas sûr de si c'est mieux de le mettre là ou ailleurs

etuutt_bot/services/sync.py Outdated Show resolved Hide resolved
imperosol
imperosol requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@imperosol imperosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Au passage, je me fais la réflexion que t'as oublié (et moi aussi quand j'ai écris le UserService) de mettre un méchanisme pour "unsync" les utilisateurs.
Là, les rôles de branche risquent pas de s'empiler semestre après semestre ?

.env.example Outdated Show resolved Hide resolved
etuutt_bot/config.py Show resolved Hide resolved
etuutt_bot/services/sync.py Outdated Show resolved Hide resolved
etuutt_bot/services/sync.py Outdated Show resolved Hide resolved
etuutt_bot/services/sync.py Outdated Show resolved Hide resolved
etuutt_bot/services/sync.py Outdated Show resolved Hide resolved
@Zalk0 @imperosol
fix: use removesuffix
cc44be9 
Co-authored-by: thomas girod <[email protected]>
@Zalk0
Copy link
Collaborator Author

Zalk0 commented Jun 4, 2024

Les rôles ne devraient pas s'empiler car on fait le "ménage" chaque semestre. C'est-à-dire on enlève les rôles d'UEs + on enlève tout le monde des rôles de branche + du rôle étudiant.
Et pour ApiUserSchema, le discord tag est forcément rempli quand un utilisateur a coché la case wantsJoinUTTDiscord tandis que sinon non donc en synchro manuelle c'est pas forcément le cas. Donc si on veut le rajouter à ApiUserSchema là il faut mettre que c'est possible que ce soit None.

@Zalk0
Copy link
Collaborator Author

Zalk0 commented Jul 10, 2024

Je peux merge ?

@Zalk0 Zalk0 requested a review from imperosol July 10, 2024 07:45
@Zalk0 Zalk0 merged commit 40fb665 into main Jul 17, 2024
3 checks passed
@Zalk0 Zalk0 deleted the daily_sync branch July 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gylfirst gylfirst gylfirst left review comments

@imperosol imperosol Awaiting requested review from imperosol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zalk0 @gylfirst @imperosol