Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove known thumbprints #52

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

unfunco
Copy link
Owner

@unfunco unfunco commented Feb 7, 2024

Starting on 6 July 2023, AWS began securing communication with GitHub's OIDC identity provider using their library of trusted Certificate Authorities instead of using a certificate thumbprint, this approach ensures that OIDC continues to work without disruption during future certificate rotations, this commit removes the known thumbprints since they are no longer necessary.

This resolves #34.

@unfunco unfunco self-assigned this Feb 7, 2024
@github-actions github-actions bot added the feature 💡 A new feature. label Feb 7, 2024
Starting on 6 July 2023, AWS began securing communication with GitHub's
OIDC identity provider using their library of trusted Certificate
Authorities instead of using a certificate thumbprint, this approach
ensures that OIDC continues to work without disruption during future
certificate rotations, this commit removes the known thumbprints since
they are no longer necessary.

This resolves #34.
@unfunco unfunco force-pushed the feat/remove-known-thumbprints branch from 8441b56 to c12abcc Compare February 7, 2024 14:59
@unfunco unfunco changed the title feat: Remove known thumbprints chore: Remove known thumbprints Feb 7, 2024
@unfunco unfunco merged commit c0b2178 into main Apr 22, 2024
13 checks passed
@unfunco unfunco deleted the feat/remove-known-thumbprints branch April 22, 2024 09:54
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💡 A new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Known thumbprints are no longer required
1 participant