ticks and toposeries animations #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
check colorbar of benchmarking topoplot |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
behinger
reviewed
Jan 24, 2025
src/plot_erpimage.jl
Outdated
| ax.xticks = round.(LinRange(minimum(times.val), maximum(times.val), 5), digits = 2) | ||
| ax.yticklabelsvisible = true | ||
|
|
||
| clims = @lift (min($filtered_data...), max($filtered_data...)) # set limits for colorbar |
There was a problem hiding this comment.
you should add a check here if the user wants to fix the colorrange in config.visual
There was a problem hiding this comment.
implemented, but in config.colormap
Co-authored-by: Benedikt Ehinger <[email protected]>
Co-authored-by: Benedikt Ehinger <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vladdez
changed the title
behinger
approved these changes
Jan 28, 2025
| @lift (min($filtered_data...), max($filtered_data...)) | ||
| ) | ||
| # Check if crange is an Observable, and extract its value if needed | ||
| crange_value = isa(crange, Observable) ? crange[] : crange |
There was a problem hiding this comment.
Suggested change
| crange_value = isa(crange, Observable) ? crange[] : crange | |
| crange_value = to_value(crange) |
| # Check if crange is an Observable, and extract its value if needed | ||
| crange_value = isa(crange, Observable) ? crange[] : crange | ||
| # Create the tick labels for the colorbar | ||
| cb_ticks = LinRange(crange_value[1], crange_value[2], 5) |
There was a problem hiding this comment.
Suggested change
| cb_ticks = LinRange(crange_value[1], crange_value[2], 5) | |
| cb_ticks = @lift LinRange($crange1], $crange[2], 5) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a page to the documentation about visualizing uncertainty in toposeries.
example_data.Toposeries
Other
alphaattribute in poly MakieOrg/Makie.jl#4614using Makiein pcp.jl