Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 5063/Fixes for white space on USFM export #9

Merged
merged 5 commits into from
Oct 23, 2018

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Oct 23, 2018

Changes

  • fixes for white space retention on alignment merge (on export)
  • added a bunch of test cases.

Testing

  • unit tests should pass on Travis

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #9 into master will increase coverage by 0.78%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   87.07%   87.86%   +0.78%     
==========================================
  Files           4        4              
  Lines         503      511       +8     
  Branches      106      108       +2     
==========================================
+ Hits          438      449      +11     
+ Misses         46       44       -2     
+ Partials       19       18       -1
Impacted Files Coverage Δ
src/js/utils/verseObjects.js 84.47% <88.88%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5acab...2fd25f6. Read the comment docs.

@PhotoNomad0 PhotoNomad0 changed the title WIP: Bugfix 5063/Fixes for white space on USFM import/export WIP: Bugfix 5063/Fixes for white space on USFM export Oct 23, 2018
@PhotoNomad0 PhotoNomad0 self-assigned this Oct 23, 2018
@PhotoNomad0 PhotoNomad0 changed the title WIP: Bugfix 5063/Fixes for white space on USFM export Bugfix 5063/Fixes for white space on USFM export Oct 23, 2018
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 12 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@richmahn richmahn merged commit 7327a56 into master Oct 23, 2018
@richmahn richmahn deleted the bugfix-mcleanb-5063 branch October 31, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants