Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 5051/Fix edge cases for merge and unmerge #8

Merged
merged 6 commits into from
Oct 16, 2018

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Oct 15, 2018

Changes

  • Fix edge cases of white space preservation and multiple instances of same greek word in an alignment.
  • add auto build on github install

Testing

  • unit tests should pass on Travis

This change is Reviewable

@PhotoNomad0 PhotoNomad0 self-assigned this Oct 15, 2018
@PhotoNomad0 PhotoNomad0 changed the title Feature mcleanb 5051/Fix edge cases merge and unmerge WIP: Feature 5051/Fix edge cases merge and unmerge Oct 15, 2018
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #8 into master will increase coverage by 0.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage    86.4%   87.07%   +0.67%     
==========================================
  Files           4        4              
  Lines         478      503      +25     
  Branches      100      106       +6     
==========================================
+ Hits          413      438      +25     
  Misses         46       46              
  Partials       19       19
Impacted Files Coverage Δ
src/js/utils/verseObjects.js 82.89% <100%> (+1.22%) ⬆️
src/js/aligner.js 90.99% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dca089...f091394. Read the comment docs.

@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature 5051/Fix edge cases merge and unmerge Feature 5051/Fix edge cases merge and unmerge Oct 16, 2018
@PhotoNomad0 PhotoNomad0 changed the title Feature 5051/Fix edge cases merge and unmerge Feature 5051/Fix edge cases for merge and unmerge Oct 16, 2018
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 19 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@richmahn richmahn merged commit 4b5acab into master Oct 16, 2018
@richmahn richmahn deleted the feature-mcleanb-5051.2 branch October 16, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants