Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 5051/Add support for nested verse Objects #6

Merged
merged 11 commits into from
Oct 12, 2018

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Oct 10, 2018

Changes

  • added support for nested verseObjects.
  • updated usfm-js module to support for new USFM 2 & 3 markers

Testing

  • unit tests should pass on Travis

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #6 into master will increase coverage by 3.83%.
The diff coverage is 97.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #6      +/-   ##
=========================================
+ Coverage   82.56%   86.4%   +3.83%     
=========================================
  Files           4       4              
  Lines         413     478      +65     
  Branches       91     100       +9     
=========================================
+ Hits          341     413      +72     
+ Misses         51      46       -5     
+ Partials       21      19       -2
Impacted Files Coverage Δ
src/js/utils/array.js 100% <100%> (ø) ⬆️
src/js/utils/verseObjects.js 81.67% <100%> (+2.67%) ⬆️
src/js/aligner.js 90.68% <94.82%> (+5.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f24f9...47dfebc. Read the comment docs.

@PhotoNomad0 PhotoNomad0 self-assigned this Oct 11, 2018
@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature 5051/Add support for nested verse Objects Feature 5051/Add support for nested verse Objects Oct 12, 2018
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 14 files at r1, 10 of 10 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@richmahn richmahn merged commit 6dca089 into master Oct 12, 2018
@PhotoNomad0 PhotoNomad0 deleted the feature-mcleanb-5051 branch October 13, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants