Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted question mark flagged in Spanish #246

Open
mandolyte opened this issue Jan 15, 2022 · 3 comments
Open

Inverted question mark flagged in Spanish #246

mandolyte opened this issue Jan 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@mandolyte
Copy link
Contributor

... at the beginning of a question. Should not be.

@mandolyte mandolyte added the bug Something isn't working label Jan 15, 2022
@RobH123
Copy link
Contributor

RobH123 commented Jan 17, 2022

Once you start widespread validating of languages other than English, I expect that you'll find MANY things like this. I have ensured that the language_code is carried through to most places it's needed, so you can either just suppress the warning notice for non-English languages, or else implement language-specific punctuation checks. (So I personally would mark this issue as an enhancement, not a bug.)

@mandolyte
Copy link
Contributor Author

mandolyte commented Jan 17, 2022 via email

@mandolyte mandolyte added enhancement New feature or request and removed bug Something isn't working labels Jan 17, 2022
@birchamp
Copy link

birchamp commented Jan 17, 2022

The problem is that when translators see any of these errors even the lowest priority warnings, they are reacting strongly to them. We have set the validation level to High by default and yet we still get editors who are pouring over each issue no matter how insignificant. Until we have a validation interface that is integrated directly into the editing process we are delaying teams every time we increase the precision of the validation.

It may be useful to have this warning above, and others like it, as a potential feature for others to develop in the future, but we’re unequipped to track the potential punctuation issues for each language with any consistency (probably even for English). I think spell checking libraries would be better at this than we ever will be. I wonder if these type of issues should be regulated to a priority number that is designated for punctuation issues that are language specific that are ignored by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants