Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Source side shows Master file for Translation mode #1634

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Joel-C-Johnson
Copy link
Collaborator

Describe what your pull request addresses (#1631 ):

  • When in translation mode(Organization other than uW), the source side should show Published resources.
  • In translationCore Create - v1.16 build 273-2ccee8b, Source side for GL org shows Master file data, however the chip on the top shows its a Published version.

Please include detailed Test instructions for your pull request:

Testing this on QA server:https://develop--tc-create-app.netlify.app/

  1. Login to uW and go to en_tn, add a test note to a tn file, save and merge the file to master. Logout
  2. Login to a GL organization e.g. translate_test, lang: other than English
  3. Open Tn and go to the same Book/file edited in step 2.
  4. Search for the test note, added in step 2. Bug: Note that the new note shows in source side.

DOD: In translation mode(Organization other than uW), the source side should show Published resources, not the master file.

@Joel-C-Johnson Joel-C-Johnson changed the title Fix - Source side shows Master file for Translation mode #1631 Fix - Source side shows Master file for Translation mode (#1631) Nov 23, 2023
@Joel-C-Johnson Joel-C-Johnson changed the title Fix - Source side shows Master file for Translation mode (#1631) Fix - Source side shows Master file for Translation mode Nov 23, 2023
@RevantCI RevantCI requested a review from abelpz November 29, 2023 07:04
Copy link
Member

@abelpz abelpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelpz abelpz merged commit 840d620 into develop Nov 30, 2023
6 of 8 checks passed
@theNerd247 theNerd247 deleted the bugFix-Joel-1631 branch November 30, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants