Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: filter out base64 encoded image fields in logs #19

Merged
merged 1 commit into from
Mar 13, 2024
Merged

refactor: filter out base64 encoded image fields in logs #19

merged 1 commit into from
Mar 13, 2024

Conversation

zehnm
Copy link
Contributor

@zehnm zehnm commented Mar 13, 2024

  • Replace base64 encoded image data in media_image_url media-player attribute fields in log messages with ***.
  • Optimize json dump: only dump once for multiple clients.
  • Only log and filter messages if DEBUG level is active.

Closes #17

@zehnm zehnm requested a review from martonborzak March 13, 2024 15:43
@zehnm zehnm self-assigned this Mar 13, 2024
@zehnm zehnm merged commit c71db60 into main Mar 13, 2024
2 checks passed
@zehnm zehnm deleted the feat/log-msg-filter branch March 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martonborzak martonborzak martonborzak approved these changes

Assignees

@zehnm zehnm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter out base64 encoded images in json message log
2 participants
@zehnm @martonborzak